Fix MSVC-specific compiler warnings / tweak method names

[ischoegl]

Changes proposed in this pull request

Over the past couple of merges, several windows (MSVC)-specific compiler warnings appeared that were not caught when developing with g++. Some of the warnings are quite long, despite being triggered by trivial causes. The following are affected:

• StoichManager.h / ThirdBodyCalc.h ... Eigen uses int to index, compared to most internal indices being size_t
• Some formatting / type-cast issues in ReactorNet.h
• Some other minor issues that resulted in warnings.
• Add missing 's' in derivative accessor names (e.g. Kinetics.net_production_rates_ddX instead of Kinetics.net_production_rate_ddX), as introduced in Sparse Jacobians for GasKinetics #1089

Checklist

• The pull request includes a clear description of this code change
• Commit messages have short titles and reference relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• Style & formatting of contributed code follows contributing guidelines
• The pull request is ready for review

[codecov]

Codecov Report

Merging #1168 (9b60e0b) into main (ec85c24) will decrease coverage by 0.00%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   65.35%   65.35%   -0.01%     
==========================================
  Files         315      315              
  Lines       45995    45999       +4     
  Branches    19531    19531              
==========================================
+ Hits        30060    30062       +2     
- Misses      13443    13445       +2     
  Partials     2492     2492              

Impacted Files	Coverage Δ
include/cantera/kinetics/ThirdBodyCalc.h	98.90% <80.00%> (-1.10%)	⬇️
include/cantera/kinetics/StoichManager.h	94.77% <88.88%> (-0.30%)	⬇️
include/cantera/base/Units.h	70.00% <100.00%> (ø)
src/base/Units.cpp	82.84% <100.00%> (ø)
src/kinetics/ReactionFactory.cpp	92.11% <100.00%> (ø)
src/oneD/Sim1D.cpp	73.63% <100.00%> (-0.07%)	⬇️
src/zeroD/ReactorNet.cpp	82.73% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec85c24...9b60e0b. Read the comment docs.

[ischoegl]

@speth ... looks like I overlooked an 's' in the accessor method names in #1089 (oops, had skipped a redundant ‘s’ on purpose when the names were longer, but with the updated ddX nomenclature this rationale does not apply). Also, it turns out that some types used by Eigen::Triplet created copious warnings in MSVC (that I didn't see as I routinely use gcc to develop). This PR should fix all of those issues (and some other minor warnings).

[speth]

Thanks for trying to clean these up. Compiler warnings that sneak in on other platforms are always kind of an unpleasant surprise when you switch to a new build environment.

[ischoegl]

@speth ... thanks for the review suggestions! I believe it's all taken care of.

[ischoegl]

This should be it though ...

[speth]

Looks good to me.

[ischoegl]

Thanks!!