fix wheel builds#1484
Merged
Merged
Conversation
bryanwweber
force-pushed
the
fix-wheel-builds
branch
from
4475f1e to
00dc0a4
Compare
ischoegl
reviewed
Apr 30, 2023
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
@bryanwweber ... thanks for taking this on. It looks like the CI failures are unrelated to changes here - now that #991 is merged, could you rebase?
bryanwweber
force-pushed
the
fix-wheel-builds
branch
from
00dc0a4 to
3001439
Compare
config.h no longer requires system-specific setup, so it can be generated at sdist build time with no problem.
Since the data folder is no longer in a fixed location relative to the tests, after moving the tests out of the package, we need to use the import location of the Cantera package to find the installed data files.
bryanwweber
force-pushed
the
fix-wheel-builds
branch
from
736338c to
1723bd7
Compare
ischoegl
approved these changes
May 7, 2023
Member
ischoegl
left a comment
ischoegl
left a comment
There was a problem hiding this comment.
Thanks, @bryanwweber! This looks good to me.
speth
approved these changes
May 9, 2023
Member
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
Thanks for getting this working again, @bryanwweber. This all looks good to me.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has changes to Cantera to support building wheels for PyPI. It's based on the
unitsbranch (#991) which has some other changes and cleanups that are useful here. This PR should be merged after that one.