-
-
Notifications
You must be signed in to change notification settings - Fork 416
Implementation of Peng-Robinson EoS #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
110 commits
Select commit
Hold shift + click to select a range
83080a1
Implementation of Peng-Robinson equation of state.
f9145df
Updating PengRobinsonMFTP_Test to clarify test composition.
decaluwe 151a486
Removing MFTP suffix from PengRobinson class
decaluwe 3fbb73f
Renaming TKelvin and cleaning up unused variables in PengRobinson.cpp
decaluwe b0d1333
Abstracting thermo calcs from PengRobinson and RedlichKwong up to Mix…
decaluwe 1bee6cf
Abstracting cubic solver to MixtureFugacityTP thermo class.
decaluwe 0ffbe6b
Add capability to load Peng Robinson via YAML.
decaluwe fa3c776
Removing xml and cti capabilities from thermo::PengRobinson.
decaluwe bc06b6d
Fix species coefficient updates in PengRobinson.
decaluwe bf5102a
Deleting test/data/co2_PR_example.cti
decaluwe 4680886
Fixing location of critProperties.xml referenced in thermo/PengRobins…
decaluwe 9f59243
Deleting commented code in thermo/PengRobinson.cpp
decaluwe c40bd53
Adding ThermoFromYAML:PengRobinson_CO2 test
decaluwe 8ee1372
Remove unnecessary overrides in MixtureFugacityTP and children
speth 09d520a
Creating python test for PengRobinson thermo class.
decaluwe 759e738
Fixing indent error in PengRobinson::updateMixingExpressions
decaluwe ffee0f7
Testing critical property lookup for PengRobinson.
decaluwe defe2df
Adding cubic solver test
decaluwe 835198e
Add functions for factory alias management
speth 8edf261
Implementation of Peng-Robinson equation of state.
fc650ad
Removing MFTP suffix from PengRobinson class
decaluwe 6ecfec3
Changing 'bad' to 'poorly' in MixtureFugacity TP error message
decaluwe d2ec337
Fixing typo in previous commit.
decaluwe 8828ef9
Fixing up merge conflicts in PengRobinson_Test.cpp
decaluwe ef8b92c
Cleaning up typos and merge conflicts.
decaluwe b8ff389
Fixing Peng-Robinson aliasing in ThermoFactory.
decaluwe dfdaa82
Fixing merge conflicts in PengRobinson_Test
decaluwe 32af524
Adding following tests to PengRobinson_Test.cpp to verify that
1eca522
Fixing indexing error in PengRobinson:d2aAlpha_dT2
decaluwe 26149ca
Cleaning up thermo/PengRobinson
decaluwe 7402961
Rename Nichols cubic solve methods as `cubicSolve`
decaluwe bb97af2
Adding detailed comments for cubic solver
gkogekar 5032994
Modifying pengRobinson test from thermoFromYAML
gkogekar 423154f
Moved setToEquil function to the parent class, 'MixtureFugacityTP".
gkogekar e6f6b9d
Removing dependancy of EoS specific omega_a, omega_b parameters from …
gkogekar 04f0a80
Cleaning up the redundant code, correcting indentations and tabs
gkogekar 92b66d5
Removed redundant calculations using a 2D array aAlpha_coeff_vec
gkogekar 29c6844
Redefined species specific internal functions as protected instead of…
gkogekar 83bc2be
Removing getChemPotentials_RT function from PengRobinsonMFTP since it is
gkogekar 768053c
Removing a_coeff_vec to avoid duplication and using m_a_vec_Curr inst…
gkogekar 7e69a65
Fixing indentation and white spaces
fded715
Modifying comments and correcting typos
df22aa7
Replacing line endings with LF instead of CRLF
891ce6c
Modified Peng-Robinson to test file to read phase from
f8d7ee0
clearing the merge-conflict
4fe68b6
Modifying the explaination for solveCubic function to be more clear and
fcab6f2
Adding a python test in interface/cython test suite
ffaaa77
Fixing error in test_thermo.py
5d67a47
Indentation changes in the PengRobinson.cpp
59e13a8
Update include/cantera/thermo/PengRobinson.h
8562bb7
Removing unused parameter m_formTempParam
gkogekar fdfcc31
Removed the changes for P-R EoS model in ctml_writer.py, since the
gkogekar bfaae6d
Replacing doublereal with double in entropy_mole function declaration
gkogekar 71f124e
Removing documentation for getChemPotential function
gkogekar 2e46979
Correcting the documentation for 'setSpeciesCoeff' and 'setBinaryCoeff'
gkogekar 61d1fe4
Removing duplication of a temp array declaration from the child classes
gkogekar 0e81424
Replacing tab character with spaces
gkogekar b57740a
Correcting the documentation for 'setBinaryCoeff' function
gkogekar f2cd14d
Correcting documentation in PengRobinson.h file
gkogekar 7d1ad7e
Added dimensions of certain vectors in the documentation
gkogekar 137deb6
Changed the function name 'pressureDerivatives' to
gkogekar 157291d
Moved 'calculateAlpha' inside the 'setSpeciesCoeff' function
gkogekar 46f3115
Changing InitThermo() to remove unused parameter a1
gkogekar 21bd4e0
Removing 'PengRobinsonMFTP' alias
gkogekar 131fa19
Cleaning up unnessesary comments.
gkogekar 5e83651
Removing 'setToEquil' function from mixtureFugacityTP class
gkogekar 91cc8df
Changing operating conditions in the pengRobinson test case
gkogekar 0687e6d
Removing redundant test from PengRobinson class tests
gkogekar 5b2e0f8
Correcting the commented documentation
gkogekar 76bb6bf
Implementation of partial internal energies
gkogekar 5d3e6df
Cleaning up functions to calculate critical properties in Redlich-Kwong
gkogekar a180bab
Defined m_a_vec_curr as the array2D type to simplify index calculations
gkogekar 1e142e4
Adding missing P-R coefficients for CO2 in co2_PR_example.yaml file
gkogekar d620b1a
Redefined variable type for coefficient `a' in P-R EoS as scalar from…
gkogekar 6823f68
Reading w_ac (acentric factor) with a more useful message that will
gkogekar 6a7f2b2
Correcting CRLF Line endings.
decaluwe 666f285
Rebasing with Cantera/main
gkogekar 404a5f7
Removing redundant _updateStateThermo() call from thermodynamic
gkogekar 4ea8da6
Combining file-base and default constructors for PengRobinson class
gkogekar 9508428
Fixing error for Peng-Robinson alias in ThermoFactory.cpp
gkogekar 5e3fb4c
Cleaning up 'thermoFromYaml.cpp'
gkogekar 7fee130
Updating PengRobinson test from thermoFromYaml.cpp
gkogekar 52e2212
Update include/cantera/thermo/PengRobinson.h
67f22f6
Update include/cantera/thermo/PengRobinson.h
4e07743
Moving declaration of the protected variable m_pp from MixtureFugacity
gkogekar 6b14db5
Cleaning up whitespaces, typos and redundant variables
gkogekar c766a9d
Wrapping up some error messages to keep the line length below 80
gkogekar fb7386f
Cleaning up whitespaces and some comments
gkogekar ec17b30
Cleaning up some more indentations errors, typos and comments
gkogekar 1f5dbe7
Update src/thermo/PengRobinson.cpp
1539bd1
Removing mistakenly added functions from RedlichKwongMFTP class.
gkogekar 8f0adc6
Adding documentation for certain functions
gkogekar d17641c
Declaring omega_a, omega_b values as private
gkogekar a0dd0c0
Renaming 'cubicSolve' to 'solveCubic'
gkogekar 2478999
Merging 'calculateAlpha' function in 'setSpeciesCoeffs'.
gkogekar 95f9a65
Removing python test for PengRobinson class
gkogekar dee71c1
Added documentation for the 'solvecubic' function
gkogekar aef53e5
Renaming _curr vector variables
gkogekar f934e50
Removing the unused function 'pressureCalc()'
gkogekar e835d17
Fixing error in 'getPartialMolarIntEnergies' function
gkogekar 2ea6496
Fixing indentations and removing redundant statements
gkogekar ffafe40
Modifying comment
228d802
Fixing indentation
9789555
Renaming w_ac to acentric_factor
gkogekar c5d4061
Modifying 'getPressure' test to cover a wider range of temperatures
gkogekar 88a10c0
Adding a test to validate P-R EoS with CoopProp
gkogekar d0f66ce
Modifying the cubic solver test
gkogekar f892c20
Adding a function to calculate partial molar specific heats
gkogekar a9e8c4d
Fixing indentation
gkogekar 5a7a938
Fixing an error in 'setBinaryCoeffs()'
gkogekar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.