Skip to content

Remove obsolete data files#923

Merged
speth merged 1 commit into
Cantera:mainfrom
ischoegl:remove-obsolete-blessed
Aug 31, 2020
Merged

Remove obsolete data files#923
speth merged 1 commit into
Cantera:mainfrom
ischoegl:remove-obsolete-blessed

Conversation

@ischoegl
Copy link
Copy Markdown
Member

@ischoegl ischoegl commented Aug 28, 2020

"Blessed" data files for regression tests have been moved to test_problems/cxx_samples (see #883), but some obsolete text files are still present in the old locations.

  • combustor: no longer produces output
  • kinetics1: output is not checked (and differs from original output)

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@ischoegl ischoegl force-pushed the remove-obsolete-blessed branch from 2e9e407 to e2c463f Compare August 28, 2020 22:51
Data files for regression tests have been moved to test_problems/cxx_samples.
Two reference output files (for combustor and kinetics1) were left behind that
are no longer relevant, as there is either no output or output has changed.
@ischoegl ischoegl force-pushed the remove-obsolete-blessed branch from e2c463f to 450c4bc Compare August 28, 2020 22:52
@speth speth merged commit 54d1fd7 into Cantera:main Aug 31, 2020
@ischoegl ischoegl deleted the remove-obsolete-blessed branch September 3, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants