Ensure consistent extra columns in SolutionArray#931
Merged
Conversation
6e6883e to
cca2fef
Compare
Member
Author
|
@speth / @bryanwweber ... I cannot request a review, but I’d appreciate if those fixes could make it into 2.5. |
ischoegl
commented
Sep 6, 2020
cca2fef to
318eedb
Compare
speth
requested changes
Dec 6, 2020
Member
speth
left a comment
There was a problem hiding this comment.
I think these are useful improvements to eliminate some confusing behavior in the SolutionArray class. Just noticed a couple of things to fix up further.
Member
Author
- Ensure consistent dimensions for extra columns - Enable multi-dimensional extra 'columns'
86f327f to
47c11ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
extracolumns are consistentextra'columns' (e.g. 2D arrays similar to what already exists for otherSolutionArrayattributes)If applicable, fill in the issue number this pull request is fixing
Fixes #895, fixes #930
Illustration
Checklist
scons build&scons test) and unit tests address code coverage