[OneD] Fix issue in Sim1D::setFixedTemperature

[ischoegl]

Changes proposed in this pull request

• Avoid exact comparison of floats as criterion whether new point needs to be added.

If applicable, fill in the issue number this pull request is fixing

Fixes #934

Checklist

• There is a clear use-case for this code change
• The commit message has a short title & references relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• The pull request is ready for review

[santoshshanbhogue]

Yup, can confirm that this fixes #934 on OSX 10.15.16. Thanks @ischoegl

`

---

*** Testing Summary ***

---

Tests passed: 1125
Up-to-date tests skipped: 0
Tests failed: 1
Failed tests:
- python:test_onedim.TestIonBurnerFlame.test_ion_profile

---

`

[ischoegl]

@santoshshanbhogue ... thank you for confirming! Per discussion, this was not caught by CI. The one remaining failure pertains to #935, which I will not address in this PR.

[speth]

Adding a tolerance here makes sense to me, but I had a couple of questions about the implementation.

[ischoegl]

@speth ... I decided to go over the code to simplify / make it more readable.

As with the other PR, I can rebase once #946 is merged.

[codecov]

Codecov Report

Merging #936 (7e949df) into main (d8e62ad) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   71.22%   71.21%   -0.01%     
==========================================
  Files         377      377              
  Lines       46272    46274       +2     
==========================================
  Hits        32955    32955              
- Misses      13317    13319       +2     

Impacted Files	Coverage Δ
src/oneD/Sim1D.cpp	81.10% <90.90%> (-0.48%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e62ad...f6c4c5b. Read the comment docs.

[speth]

Looks good to me. I think this can be merged as soon as the tests pass.