Skip to content

[thermo] Throw IndexError for invalid species index #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
speth merged 1 commit into from
Jan 18, 2021
Merged

[thermo] Throw IndexError for invalid species index #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions interfaces/cython/cantera/test/test_thermo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ def test_species(self):
self.assertEqual(name, self.phase.species_name(i))
self.assertEqual(i, self.phase.species_index(name))
self.assertEqual(i, self.phase.species_index(i))
with self.assertRaisesRegex(ct.CanteraError, 'IndexError thrown by Phase::checkSpeciesIndex'):
self.phase.species(self.phase.n_species)

def test_elements(self):
self.assertEqual(self.phase.n_elements, 3)
Expand Down
1 change: 1 addition & 0 deletions src/thermo/Phase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,7 @@ shared_ptr<Species> Phase::species(const std::string& name) const

shared_ptr<Species> Phase::species(size_t k) const
{
checkSpeciesIndex(k);
return m_species.at(m_speciesNames[k]);
}

Expand Down