Fix copy-bulk.sh and optimise dependencies#42
Merged
Silic0nS0ldier merged 3 commits intomainfrom Dec 6, 2023
Merged
Conversation
christianscott
suggested changes
Dec 5, 2023
Contributor
christianscott
left a comment
christianscott
left a comment
There was a problem hiding this comment.
Why do we need to remove pipefail?
Contributor
Author
Because I wrote the script to use The suggestion of outright using |
Silic0nS0ldier
changed the title
pipefail bashism from POSIX shell scriptcopy-bulk.sh and optimise dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shell usage and optimises dependency logic (gains will be more noticeable with bazelbuild/bazel#20434).