Refactor pkg_npm to support caching and remove the embedded package path#43
Merged
Silic0nS0ldier merged 1 commit intomainfrom Dec 8, 2023
Merged
Conversation
christianscott
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing
localfromexecution_requirementsin favour ofno-remote-execandno-sandboxso actions can be cached.Embedded package path replaced with reference to
TreeArtifactoutput (referenced via$(location :%s)). This also appears to address an issue wherenpm packfails with exit code254, however the issue manifested as a flake so there is a chance it lingers on. Regardless, this is a safer way to reference inputs.