Skip to content

Hook to run command before node_modules installed #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Silic0nS0ldier merged 6 commits into from
Jan 24, 2024
Merged

Hook to run command before node_modules installed #46

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85ca699
Hook to run command before `node_modules` installed
Silic0nS0ldier Jan 14, 2024
7aefdff
Add `env`
Silic0nS0ldier Jan 24, 2024
0c6d28b
Merge remote-tracking branch 'origin/main' into jordan-mele_preinstal…
Silic0nS0ldier Jan 24, 2024
add69ab
`report_process` -> `report_progess`
Silic0nS0ldier Jan 24, 2024
8df01ec
`report_progess -> `report_progress`
Silic0nS0ldier Jan 24, 2024
f9f1f89
`repository_ctx.execute` wants `string` not `path` for `working_direc…
Silic0nS0ldier Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions internal/npm_install/npm_install.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,13 @@ data attribute.
default = 3600,
doc = """Maximum duration of the package manager execution in seconds.""",
),
"preinstall_cmd": attr.string_list(
doc = """
Command to run before installing `node_modules`.

First argument must be an exectuable, CWD will be that of package directory.
""",
),
"_inputs": attr.label_list(
default = [
"//internal/npm_install:pre_process_package_json.js",
Expand All @@ -333,6 +340,19 @@ PROXY_ENVVARS = [
"all_proxy",
]

def _run_preinstall_cmd(repository_ctx, env):
if len(repository_ctx.attr.preinstall_cmd) > 0:
repository_ctx.report_progress("Running preinstall command")
result = repository_ctx.execute(
repository_ctx.attr.preinstall_cmd,
timeout = repository_ctx.attr.timeout,
quiet = repository_ctx.attr.quiet,
environment = env,
working_directory = str(repository_ctx.path(repository_ctx.attr.package_json).dirname),
)
if result.return_code:
fail("preinstall command failed: %s (%s)" % (result.stdout, result.stderr))

def _apply_pre_install_patches(repository_ctx):
if len(repository_ctx.attr.pre_install_patches) == 0:
return
Expand Down Expand Up @@ -685,6 +705,8 @@ cd /D "{root}" && "{npm}" {npm_args}

env = _propagate_http_proxy_env(repository_ctx, env)

_run_preinstall_cmd(repository_ctx, env)

# NB: after running npm install, it's essential that we don't cause the repository rule to restart
# This means we must not reference any additional labels after this point.
# See https://github.com/bazelbuild/rules_nodejs/issues/2620
Expand Down Expand Up @@ -852,6 +874,8 @@ cd /D "{root}" && "{yarn}" {yarn_args}

env = _propagate_http_proxy_env(repository_ctx, env)

_run_preinstall_cmd(repository_ctx, env)

repository_ctx.report_progress("Running yarn install on %s" % repository_ctx.attr.package_json)
result = repository_ctx.execute(
[repository_ctx.path("_yarn.cmd" if is_windows_host else "_yarn.sh")],
Expand Down