Skip to content

fail if node_modules not created after running _yarn.sh #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianscott merged 1 commit into from
Jan 23, 2024
Merged

fail if node_modules not created after running _yarn.sh #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/npm_install/npm_install.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,10 @@ def _yarn_install_impl(repository_ctx):
set -e
export YARN_IGNORE_PATH=1
(cd "{root}"; "{yarn}" {yarn_args})
if ! [[ -d "{root}/node_modules" ]]; then
echo "node_modules directory not found after yarn install, finished in $SECONDS seconds"
exit 1
fi
""".format(
root = root,
yarn = repository_ctx.path(yarn),
Expand Down