Match Bazel env attribute behaviour#52
Merged
Silic0nS0ldier merged 2 commits intomainfrom Mar 13, 2024
Merged
Conversation
christianscott
approved these changes
Mar 13, 2024
| # since this will be called from a nodejs_test, where the entrypoint is going to be the test file | ||
| # we shouldn't add the entrypoint as a attribute to collect here | ||
| coverage_common.instrumented_files_info(ctx, dependency_attributes = ["data"], extensions = ["js", "ts"]), | ||
| RunEnvironmentInfo(expanded_env), |
Contributor
There was a problem hiding this comment.
This means it doesn't get the right env when run directly in bazel-bin right? Or when run as a data dependency in the runfiles of something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR;
envwere being filtered out.RunEnvironmentInfoprovider.envbehaviour with behaviour defined in "common definitions" documentation (testandrunonly).Since environment variables are now passed along via a provider, they won't be an input for building
nodejs_binaryandnodejs_testtargets.TODO
Test underbuild.Does not work in
genrule.According to Bazel docs,
envwas never supposed to apply to builds. This is a bug in Rules NodeJS v3.8.test.run.run --script_path