Skip to content

Support --incompatible_struct_has_no_methods for Bazel 8 preview #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Silic0nS0ldier merged 1 commit into from
Jul 1, 2024
Merged

Support --incompatible_struct_has_no_methods for Bazel 8 preview #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/npm_install/npm_install.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ def _create_build_files(repository_ctx, rule_type, node, lock_file, generate_loc
if not v.startswith("@"):
fail("link target must be label of form '@wksp//path/to:target', '@//path/to:target' or '//path/to:target'")
validated_links[k] = v
generate_config_json = struct(
generate_config_json = json.encode(struct(
exports_directories_only = repository_ctx.attr.exports_directories_only,
generate_local_modules_build_files = generate_local_modules_build_files,
included_files = repository_ctx.attr.included_files,
Expand All @@ -454,7 +454,7 @@ def _create_build_files(repository_ctx, rule_type, node, lock_file, generate_loc
strict_visibility = repository_ctx.attr.strict_visibility,
workspace = repository_ctx.attr.name,
workspace_rerooted_path = _WORKSPACE_REROOTED_PATH,
).to_json()
))
repository_ctx.file("generate_config.json", generate_config_json)
result = repository_ctx.execute(
[node, "index.js"],
Expand Down