Skip to content
This repository was archived by the owner on May 1, 2026. It is now read-only.

fix: add platform and build_mode to top-level request payload#531

Merged
WcaleNieWolny merged 1 commit into
mainfrom
fix/platform-top-level-payload
Feb 28, 2026
Merged

fix: add platform and build_mode to top-level request payload#531
WcaleNieWolny merged 1 commit into
mainfrom
fix/platform-top-level-payload

Conversation

@WcaleNieWolny
Copy link
Copy Markdown
Contributor

@WcaleNieWolny WcaleNieWolny commented Feb 28, 2026

Summary

  • Adds platform and build_mode to the top-level request payload sent to POST /build/request
  • The capgo proxy validates platform at the root level before forwarding to the builder — without this the API returns "platform is required"

Test plan

  • Run npx @capgo/cli build --platform android and confirm the request includes top-level platform
  • Verify the proxy no longer returns "platform is required"

Summary by CodeRabbit

  • New Features
    • Build requests now include platform information and configurable build mode settings, with 'release' as the default build mode when not explicitly specified.

The capgo proxy expects platform at the root level of the request body
to validate the build request. Without this, the API returns
"platform is required". Also bumps version to 7.83.0.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a62fbe and 5c7ef9b.

📒 Files selected for processing (1)
  • src/build/request.ts

📝 Walkthrough

Walkthrough

This PR augments the native build request payload in src/build/request.ts by adding two new fields: platform (sourced from options.platform) and build_mode (defaulting to 'release' when not explicitly provided).

Changes

Cohort / File(s) Summary
Build Request Enhancement
src/build/request.ts
Add platform and build_mode fields to the native build request payload for improved build configuration tracking.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A dash of platform here, a mode so clean,
Two fields that make the build complete and keen,
Release by default, unless you say,
Now builds are tracked in every way! 🎉

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/platform-top-level-payload

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@WcaleNieWolny WcaleNieWolny marked this pull request as ready for review February 28, 2026 18:09
@WcaleNieWolny WcaleNieWolny merged commit 699515b into main Feb 28, 2026
13 of 14 checks passed
@sonarqubecloud
Copy link
Copy Markdown

@riderx riderx deleted the fix/platform-top-level-payload branch March 17, 2026 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant