fix: improve init onboarding UX for app add step#562
Conversation
- Merge two redundant confirm prompts ("Is this the correct app ID?" +
"Add in Capgo?") into a single select with emoji labels
- Fix duplicate app ID error not being caught (Supabase returns
"duplicate key" / code 23505, not "already exist")
- Skip checkAlerts() in addAppInternal when called silently from init
to avoid flashing clack output during Ink session
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo refinements to app initialization: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3610e73218
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| options: [ | ||
| { value: 'yes', label: '✅ Yes, add it' }, | ||
| { value: 'change', label: '❌ No, use a different app ID' }, | ||
| ], |
There was a problem hiding this comment.
Preserve a path to continue onboarding without app creation
This select now only offers yes or change, which removes the previous doAdd === false branch that let users skip app creation and continue onboarding. In environments where users intentionally postpone server-side changes (or temporarily can’t create the app), step 1 becomes a hard blocker and the only escape is canceling onboarding entirely, which is a functional regression from the prior flow.
Useful? React with 👍 / 👎.



Summary
Add com.example.app to Capgo?with✅ Yes, add it/❌ No, use a different app ID"duplicate key value violates unique constraint"(code 23505), but the handler only checked for"already exist". Now the existing recovery flow (suggest alternatives) triggers correctlycheckAlerts()inaddAppInternalwhen called withsilent=truefrom init, preventing clack output from flashing during the Ink sessionTest plan
node dist/index.js i— app add step should show a single select prompt, not two confirmsSummary by CodeRabbit
Improvements
Bug Fixes