fix: remove SQL tests from migration file#1348
Conversation
Tests should never run in production migrations. The hashed API key functionality is already covered by comprehensive tests in tests/apikeys.test.ts. Removed the DO block that was creating and deleting test data during migration. 🤖 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe migration file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tests should never run in production migrations. The hashed API key functionality is already covered by comprehensive tests in tests/apikeys.test.ts. Removed the DO block that was creating and deleting test data during migration. 🤖 Generated with Claude Code Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>



Summary
Removed inline SQL tests from the hashed API keys migration. Tests should never run in production migrations—they're already covered by comprehensive integration tests in
tests/apikeys.test.ts.Test plan
bun test:backend tests/apikeys.test.tsto verify hashed API key functionality is tested🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.