-
-
Notifications
You must be signed in to change notification settings - Fork 127
Add manifest diff tab and compare UX #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |||||||||||||||||||||||||||||||||||||||||||||
| "making-this-channel-": "Hacer este canal \"normal\" requerirá que configures otro canal predeterminado o dejes que el dispositivo se asigne automáticamente.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manage-default-channel": "Administrar en la configuración de la aplicación", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest": "Manifiesto", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-label": "Compare with bundle", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-none": "All files (no comparison)", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-latest": "Latest bundles", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-results": "Search results", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-summary-files": "Files", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
887
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New manifest strings are not localized (es.json still contains English). Either translate these values to Spanish or remove them to fall back to the default locale (so users don’t see a partially-English UI). Placeholders Proposed Spanish translations (optional) "manifest": "Manifiesto",
- "manifest-compare-label": "Compare with bundle",
- "manifest-compare-none": "All files (no comparison)",
- "manifest-compare-latest": "Latest bundles",
- "manifest-compare-results": "Search results",
- "manifest-summary-files": "Files",
- "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.",
- "manifest-status-full": "Showing full manifest for this bundle.",
- "manifest-status-diff": "Showing {count} files that differ from {bundle}.",
- "manifest-status-compare-empty": "We could not find any files for {bundle}.",
- "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.",
+ "manifest-compare-label": "Comparar con paquete",
+ "manifest-compare-none": "Todos los archivos (sin comparación)",
+ "manifest-compare-latest": "Últimos paquetes",
+ "manifest-compare-results": "Resultados de búsqueda",
+ "manifest-summary-files": "Archivos",
+ "manifest-download-estimate-note": "Los tamaños mostrados son la descarga máxima posible para esta comparación; las descargas reales pueden ser menores.",
+ "manifest-status-full": "Mostrando el manifiesto completo para este paquete.",
+ "manifest-status-diff": "Mostrando {count} archivos que difieren de {bundle}.",
+ "manifest-status-compare-empty": "No pudimos encontrar ningún archivo para {bundle}.",
+ "manifest-diff-empty": "Encontramos archivos en ambos paquetes, pero ninguno difiere — los dispositivos descargarían 0 archivos.",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||
| "mau": "Usuarios activos mensuales", | ||||||||||||||||||||||||||||||||||||||||||||||
| "mau-limit-exceeded": "Límite de MAU excedido", | ||||||||||||||||||||||||||||||||||||||||||||||
| "mau-trend": "Tendencia MAU", | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |||||||||||||||||||||||||||||||||||||||||||||
| "making-this-channel-": "Pour rendre cette chaîne \"normale\", vous devrez configurer une autre chaîne par défaut ou laisser l'appareil s'attribuer lui-même.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manage-default-channel": "Gérer les paramètres dans l'application", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest": "Manifeste", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-label": "Compare with bundle", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-none": "All files (no comparison)", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-latest": "Latest bundles", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-results": "Search results", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-summary-files": "Files", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||||||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
887
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New manifest strings are not localized (fr.json still contains English). Same suggestion as es.json: translate or drop these keys and rely on fallback locale. Placeholders Proposed French translations (optional) "manifest": "Manifeste",
- "manifest-compare-label": "Compare with bundle",
- "manifest-compare-none": "All files (no comparison)",
- "manifest-compare-latest": "Latest bundles",
- "manifest-compare-results": "Search results",
- "manifest-summary-files": "Files",
- "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.",
- "manifest-status-full": "Showing full manifest for this bundle.",
- "manifest-status-diff": "Showing {count} files that differ from {bundle}.",
- "manifest-status-compare-empty": "We could not find any files for {bundle}.",
- "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.",
+ "manifest-compare-label": "Comparer avec un paquet",
+ "manifest-compare-none": "Tous les fichiers (sans comparaison)",
+ "manifest-compare-latest": "Derniers paquets",
+ "manifest-compare-results": "Résultats de recherche",
+ "manifest-summary-files": "Fichiers",
+ "manifest-download-estimate-note": "Les tailles affichées correspondent au téléchargement maximal possible pour cette comparaison ; le téléchargement réel peut être inférieur.",
+ "manifest-status-full": "Affichage du manifeste complet pour ce paquet.",
+ "manifest-status-diff": "Affichage de {count} fichiers qui diffèrent de {bundle}.",
+ "manifest-status-compare-empty": "Aucun fichier trouvé pour {bundle}.",
+ "manifest-diff-empty": "Des fichiers ont été trouvés dans les deux paquets, mais aucun ne diffère — les appareils téléchargeraient 0 fichier.",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||
| "mau": "Utilisateurs actifs mensuels", | ||||||||||||||||||||||||||||||||||||||||||||||
| "mau-limit-exceeded": "Limite MAU dépassée", | ||||||||||||||||||||||||||||||||||||||||||||||
| "mau-trend": "Tendance MAU", | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "इस चैनल को \"सामान्य\" बनाने के लिए आपको किसी अन्य चैनल को डिफ़ॉल्ट सेट करने की या डिवाइस को स्वत: सेट होने की ज़रुरत पड़ेगी.", | ||
| "manage-default-channel": "ऐप सेटिंग्स में प्रबंधन करें", | ||
| "manifest": "मैनिफ़ेस्ट", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
| "mau": "मासिक सक्रिय उपयोगकर्ता", | ||
|
Comment on lines
887
to
898
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hindi locale file contains English strings for new manifest keys. 🤖 Prompt for AI Agents |
||
| "mau-limit-exceeded": "MAU सीमा पार हो गई", | ||
| "mau-trend": "MAU प्रवृत्ति", | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |||||||||||||||||||||||||||||||||||||||||
| "making-this-channel-": "Membuat saluran ini \"normal\" akan memerlukan Anda untuk mengkonfigurasi saluran default lain atau membiarkan perangkat menetapkan sendiri.", | ||||||||||||||||||||||||||||||||||||||||||
| "manage-default-channel": "Kelola di Pengaturan Aplikasi", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest": "Manifest", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-label": "Compare with bundle", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-none": "All files (no comparison)", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-latest": "Latest bundles", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-results": "Search results", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-summary-files": "Files", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+888
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indonesian locale: new manifest strings are still English Lines 888-897 should be translated for Proposed diff (Indonesian copy) "manifest": "Manifest",
- "manifest-compare-label": "Compare with bundle",
- "manifest-compare-none": "All files (no comparison)",
- "manifest-compare-latest": "Latest bundles",
- "manifest-compare-results": "Search results",
- "manifest-summary-files": "Files",
- "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.",
- "manifest-status-full": "Showing full manifest for this bundle.",
- "manifest-status-diff": "Showing {count} files that differ from {bundle}.",
- "manifest-status-compare-empty": "We could not find any files for {bundle}.",
- "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.",
+ "manifest-compare-label": "Bandingkan dengan bundel",
+ "manifest-compare-none": "Semua file (tanpa perbandingan)",
+ "manifest-compare-latest": "Bundel terbaru",
+ "manifest-compare-results": "Hasil pencarian",
+ "manifest-summary-files": "File",
+ "manifest-download-estimate-note": "Ukuran yang ditampilkan adalah perkiraan unduhan maksimum untuk perbandingan ini; unduhan sebenarnya bisa lebih kecil.",
+ "manifest-status-full": "Menampilkan manifest lengkap untuk bundel ini.",
+ "manifest-status-diff": "Menampilkan {count} file yang berbeda dari {bundle}.",
+ "manifest-status-compare-empty": "Kami tidak dapat menemukan file apa pun untuk {bundle}.",
+ "manifest-diff-empty": "Kami menemukan file di kedua bundel, tetapi tidak ada yang berbeda — perangkat akan mengunduh 0 file.",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||
| "mau": "Pengguna aktif bulanan", | ||||||||||||||||||||||||||||||||||||||||||
| "mau-limit-exceeded": "Batas MAU telah terlampaui", | ||||||||||||||||||||||||||||||||||||||||||
| "mau-trend": "Tren MAU", | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "Per rendere questo canale \"normale\", sarà necessario configurare un altro canale predefinito o lasciare che il dispositivo si assegni autonomamente.", | ||
| "manage-default-channel": "Gestisci nelle impostazioni dell'app", | ||
| "manifest": "Manifesto", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
|
Comment on lines
+888
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Italian locale has English strings for new manifest UI keys. These entries should be Italian (or removed to rely on fallback if supported). Preserve 🤖 Prompt for AI Agents |
||
| "mau": "Utenti attivi mensilmente", | ||
| "mau-limit-exceeded": "Limite MAU superato", | ||
| "mau-trend": "Tendenza MAU", | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |||||||||||||||||||||||||||||||||||||||||
| "making-this-channel-": "このチャンネルを「通常」にするためには、他のチャンネルをデフォルトに設定するか、デバイスが自己割り当てを行う必要があります。", | ||||||||||||||||||||||||||||||||||||||||||
| "manage-default-channel": "アプリ設定を管理する", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest": "マニフェスト", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-label": "Compare with bundle", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-none": "All files (no comparison)", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-latest": "Latest bundles", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-compare-results": "Search results", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-summary-files": "Files", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||||||||||||||||||||||||||||||||||||||||||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+888
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Japanese locale: new manifest strings are still English Lines 888-897 are English copy inside Proposed diff (Japanese copy) "manifest": "マニフェスト",
- "manifest-compare-label": "Compare with bundle",
- "manifest-compare-none": "All files (no comparison)",
- "manifest-compare-latest": "Latest bundles",
- "manifest-compare-results": "Search results",
- "manifest-summary-files": "Files",
- "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.",
- "manifest-status-full": "Showing full manifest for this bundle.",
- "manifest-status-diff": "Showing {count} files that differ from {bundle}.",
- "manifest-status-compare-empty": "We could not find any files for {bundle}.",
- "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.",
+ "manifest-compare-label": "バンドルと比較",
+ "manifest-compare-none": "すべてのファイル(比較なし)",
+ "manifest-compare-latest": "最新のバンドル",
+ "manifest-compare-results": "検索結果",
+ "manifest-summary-files": "ファイル",
+ "manifest-download-estimate-note": "表示されるサイズはこの比較での最大ダウンロード量の見積もりです。実際のダウンロードはより小さくなる場合があります。",
+ "manifest-status-full": "このバンドルのマニフェスト全体を表示しています。",
+ "manifest-status-diff": "{bundle} と異なるファイル {count} 件を表示しています。",
+ "manifest-status-compare-empty": "{bundle} のファイルが見つかりませんでした。",
+ "manifest-diff-empty": "両方のバンドルにファイルはありますが差分はありません — デバイスは 0 ファイルをダウンロードします。",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||
| "mau": "月間アクティブユーザー", | ||||||||||||||||||||||||||||||||||||||||||
| "mau-limit-exceeded": "MAU制限を超えました", | ||||||||||||||||||||||||||||||||||||||||||
| "mau-trend": "MAUトレンド", | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "이 채널을 \"정상\"으로 만들려면 다른 채널을 기본값으로 설정하거나 장치가 자체 할당하도록 해야 합니다.", | ||
| "manage-default-channel": "앱 설정 관리", | ||
| "manifest": "매니페스트", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
| "mau": "월간 활성 사용자", | ||
|
Comment on lines
887
to
898
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Korean locale file contains English strings for new manifest keys. 🤖 Prompt for AI Agents |
||
| "mau-limit-exceeded": "MAU 한도 초과", | ||
| "mau-trend": "MAU 추세", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "Aby uczynić ten kanał \"normalnym\", musisz skonfigurować inny domyślny kanał lub pozwolić urządzeniu na samodzielne przypisanie.", | ||
| "manage-default-channel": "Zarządzaj w ustawieniach aplikacji", | ||
| "manifest": "Manifest", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
|
Comment on lines
+888
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Polish locale has English strings for new manifest UI keys. Same concern as 🤖 Prompt for AI Agents |
||
| "mau": "Miesięczni aktywni użytkownicy", | ||
| "mau-limit-exceeded": "Przekroczono limit MAU", | ||
| "mau-trend": "Trend MAU", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "Tornar este canal \"normal\" exigirá que você configure outro canal como padrão ou permita que o dispositivo se auto atribua.", | ||
| "manage-default-channel": "Gerenciar nas configurações do aplicativo", | ||
| "manifest": "Manifesto", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
|
Comment on lines
+888
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New manifest strings are in English for pt-BR—confirm intent or provide translations. These new 🤖 Prompt for AI Agents |
||
| "mau": "Usuários ativos mensais", | ||
| "mau-limit-exceeded": "Limite do MAU excedido", | ||
| "mau-trend": "Tendência MAU", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "Чтобы сделать этот канал \"нормальным\", вам потребуется настроить другой канал по умолчанию или позволить устройству самостоятельно назначить его.", | ||
| "manage-default-channel": "Управление в настройках приложения", | ||
| "manifest": "Манифест", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
|
Comment on lines
+888
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Search for i18n configuration files and fallback locale settings
find . -type f \( -name "*.json" -o -name "*.js" -o -name "*.ts" -o -name "*.vue" \) | head -20
echo "---"
# Look for i18n configuration
rg -l "fallbackLocale|createI18n|i18n" --type js --type ts --type vue --type json | head -20Repository: Cap-go/capgo Length of output: 732 🏁 Script executed: #!/bin/bash
# Find the messages directory structure and check both en and ru files
fd "messages" -t d
echo "---"
ls -la messages/ 2>/dev/null || echo "messages dir not found at root"Repository: Cap-go/capgo Length of output: 1157 🏁 Script executed: #!/bin/bash
# Search for i18n configuration patterns
rg -n "fallbackLocale|fallback|defaultLocale" --type js --type ts --type vueRepository: Cap-go/capgo Length of output: 83 🏁 Script executed: #!/bin/bash
# Check if the keys in question exist in en.json
rg "manifest-compare-label|manifest-compare-none|manifest-status-diff" messages/Repository: Cap-go/capgo Length of output: 3613 🏁 Script executed: #!/bin/bash
# Find i18n setup files
fd "i18n|locale" -type f | grep -E "\.(ts|js)$" | head -20Repository: Cap-go/capgo Length of output: 226 🏁 Script executed: #!/bin/bash
# Search for i18n initialization or configuration without vue type
rg "createI18n|i18n\s*=" -A 5 -B 2 --type ts --type jsRepository: Cap-go/capgo Length of output: 697 🏁 Script executed: #!/bin/bash
# Check all manifest keys in en.json and ru.json to compare
echo "=== en.json manifest keys ==="
rg "manifest-" messages/en.json | wc -l
echo "=== ru.json manifest keys ==="
rg "manifest-" messages/ru.json | wc -l
echo "---"
# Check specific keys
echo "Keys in en.json:"
rg "manifest-" messages/en.json | head -15
echo "---"
echo "Keys in ru.json:"
rg "manifest-" messages/ru.json | head -15Repository: Cap-go/capgo Length of output: 2364 🏁 Script executed: #!/bin/bash
# Read the full i18n.ts file
cat -n src/modules/i18n.tsRepository: Cap-go/capgo Length of output: 2548 🏁 Script executed: #!/bin/bash
# Also search for where messages are loaded into the i18n config
rg "messages\[|messages\." --type ts -B 3 -A 3 | head -50Repository: Cap-go/capgo Length of output: 4300 Provide Russian translations for untranslated manifest strings in The new manifest-* keys currently contain English text in To fix this, either:
Ensure placeholder formatting ( 🤖 Prompt for AI Agents |
||
| "mau": "Ежемесячно активные пользователи", | ||
| "mau-limit-exceeded": "Превышен лимит MAU", | ||
| "mau-trend": "Тренд MAU", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "Bu kanalı \"normal\" yapmak için başka bir kanalı varsayılan olarak yapılandırmanız veya cihazın kendisine atamasına izin vermeniz gerekecektir.", | ||
| "manage-default-channel": "Uygulama ayarlarını yönetin", | ||
| "manifest": "Manifest", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
|
Comment on lines
887
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New manifest strings are not localized (tr.json still contains English). Please translate these values to Turkish (or remove to rely on fallback locale), otherwise the UI will show English strings even in 🤖 Prompt for AI Agents |
||
| "mau": "Aylık aktif kullanıcılar", | ||
| "mau-limit-exceeded": "MAU limiti aşıldı", | ||
| "mau-trend": "MAU Trendi", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -886,6 +886,16 @@ | |
| "making-this-channel-": "Để làm cho kênh này \"bình thường\", bạn sẽ cần cấu hình một kênh mặc định khác hoặc để thiết bị tự gán.", | ||
| "manage-default-channel": "Quản lý trong cài đặt ứng dụng", | ||
| "manifest": "Manifest", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
|
Comment on lines
+889
to
+898
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New manifest strings are in English for vi—confirm intent or provide translations. These 🤖 Prompt for AI Agents |
||
| "mau": "Người dùng hoạt động hàng tháng", | ||
| "mau-limit-exceeded": "Vượt quá giới hạn MAU", | ||
| "mau-trend": "Xu hướng MAU", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -885,6 +885,16 @@ | |
| "making-this-channel-": "使此频道\"正常\"将需要您配置其他默认频道或让设备自行分配。", | ||
| "manage-default-channel": "在应用设置中管理", | ||
| "manifest": "清单", | ||
| "manifest-compare-label": "Compare with bundle", | ||
| "manifest-compare-none": "All files (no comparison)", | ||
| "manifest-compare-latest": "Latest bundles", | ||
| "manifest-compare-results": "Search results", | ||
| "manifest-summary-files": "Files", | ||
| "manifest-download-estimate-note": "Sizes shown are the maximum possible download for this comparison; actual downloads can be smaller.", | ||
| "manifest-status-full": "Showing full manifest for this bundle.", | ||
| "manifest-status-diff": "Showing {count} files that differ from {bundle}.", | ||
| "manifest-status-compare-empty": "We could not find any files for {bundle}.", | ||
| "manifest-diff-empty": "We found files in both bundles, but none differ — devices would download 0 files.", | ||
|
Comment on lines
+888
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New manifest strings are in English for zh-CN—confirm intent or provide translations. The newly added 🤖 Prompt for AI Agents |
||
| "mau": "月活跃用户", | ||
| "mau-limit-exceeded": "超过MAU限制", | ||
| "mau-trend": "MAU趋势", | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,11 +1,13 @@ | ||||||||||||||||||||||||||
| import type { Tab } from '~/components/comp_def' | ||||||||||||||||||||||||||
| import IconManifest from '~icons/heroicons/clipboard-document-list' | ||||||||||||||||||||||||||
| import IconHistory from '~icons/heroicons/clock' | ||||||||||||||||||||||||||
| import IconEye from '~icons/heroicons/eye' | ||||||||||||||||||||||||||
| import IconInfo from '~icons/heroicons/information-circle' | ||||||||||||||||||||||||||
| import IconPuzzle from '~icons/heroicons/puzzle-piece' | ||||||||||||||||||||||||||
|
Comment on lines
1
to
6
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix import ordering to satisfy ESLint (currently a lint error). Proposed diff (one possible ordering) import type { Tab } from '~/components/comp_def'
-import IconHistory from '~icons/heroicons/clock'
-import IconManifest from '~icons/heroicons/clipboard-document-list'
import IconEye from '~icons/heroicons/eye'
+import IconHistory from '~icons/heroicons/clock'
import IconInfo from '~icons/heroicons/information-circle'
+import IconManifest from '~icons/heroicons/clipboard-document-list'
import IconPuzzle from '~icons/heroicons/puzzle-piece'📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| export const bundleTabs: Tab[] = [ | ||||||||||||||||||||||||||
| { label: 'info', icon: IconInfo, key: '' }, | ||||||||||||||||||||||||||
| { label: 'manifest', icon: IconManifest, key: '/manifest' }, | ||||||||||||||||||||||||||
| { label: 'dependencies', icon: IconPuzzle, key: '/dependencies' }, | ||||||||||||||||||||||||||
| { label: 'history', icon: IconHistory, key: '/history' }, | ||||||||||||||||||||||||||
| { label: 'preview-tab', icon: IconEye, key: '/preview' }, | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
German locale: new manifest strings are still English (user-visible i18n regression)
Lines 888-897 add German-locale keys but keep English copy; either translate them or omit them and rely on fallback (depending on how i18n fallback is configured). Also keep
{count}/{bundle}placeholders unchanged.Proposed diff (German copy)
📝 Committable suggestion
🤖 Prompt for AI Agents