Skip to content

[codex] Remove no-apps subscription confirmation dialog#1880

Merged
riderx merged 1 commit into
mainfrom
codex/remove-no-apps-subscription-dialog
Apr 1, 2026
Merged

[codex] Remove no-apps subscription confirmation dialog#1880
riderx merged 1 commit into
mainfrom
codex/remove-no-apps-subscription-dialog

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented Apr 1, 2026

Summary (AI generated)

  • remove the no-apps subscription confirmation dialog from organization plan checkout
  • delete the now-unused locale keys tied to that dialog across all shipped translations

Motivation (AI generated)

The no-apps warning was introduced when Capgo auto-created apps for new users. That is no longer true, so the extra confirmation is outdated and creates unnecessary friction for valid billing flows.

Business Impact (AI generated)

This reduces checkout friction for organizations that are ready to subscribe before creating their first app, which should improve conversion and remove a misleading warning from the billing flow.

Test Plan (AI generated)

  • bun lint
  • bun typecheck
  • PLAYWRIGHT_HEADLESS=1 bun run test:front (fails in unrelated existing specs under playwright/e2e/apikeys.spec.ts, playwright/e2e/auth.spec.ts, playwright/e2e/register.spec.ts, and playwright/e2e/sso-login.spec.ts)

Generated with AI

Summary by CodeRabbit

  • Chores

    • Removed localization strings for app management and subscription features across all 17 supported languages.
  • Refactor

    • Simplified the organization plan change process.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22d47fcd-b1b5-44d0-b7d1-e5d727cb0bea

📥 Commits

Reviewing files that changed from the base of the PR and between 3fd1ec7 and 9160781.

📒 Files selected for processing (16)
  • messages/de.json
  • messages/en.json
  • messages/es.json
  • messages/fr.json
  • messages/hi.json
  • messages/id.json
  • messages/it.json
  • messages/ja.json
  • messages/ko.json
  • messages/pl.json
  • messages/pt-br.json
  • messages/ru.json
  • messages/tr.json
  • messages/vi.json
  • messages/zh-cn.json
  • src/pages/settings/organization/Plans.vue
💤 Files with no reviewable changes (16)
  • src/pages/settings/organization/Plans.vue
  • messages/id.json
  • messages/vi.json
  • messages/fr.json
  • messages/pt-br.json
  • messages/it.json
  • messages/ru.json
  • messages/es.json
  • messages/de.json
  • messages/ja.json
  • messages/hi.json
  • messages/en.json
  • messages/tr.json
  • messages/pl.json
  • messages/ko.json
  • messages/zh-cn.json

📝 Walkthrough

Walkthrough

This PR removes five localization keys (no-apps-confirm-subscription, no-apps-in-org, other-orgs-with-apps, proceed-anyway, switch-to) from all message locale files, and removes the corresponding no-apps confirmation dialog flow from the Plans.vue component.

Changes

Cohort / File(s) Summary
Message Localization Cleanup
messages/de.json, messages/en.json, messages/es.json, messages/fr.json, messages/hi.json, messages/id.json, messages/it.json, messages/ja.json, messages/ko.json, messages/pl.json, messages/pt-br.json, messages/ru.json, messages/tr.json, messages/vi.json, messages/zh-cn.json
Removed 5 translation keys across all locales: no-apps-confirm-subscription, no-apps-in-org, other-orgs-with-apps, proceed-anyway, and switch-to.
Plans Component Update
src/pages/settings/organization/Plans.vue
Removed the conditional no-apps confirmation dialog branch (~67 lines) that displayed other super-admin organizations with apps and required user action before proceeding with plan changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

enhancement

Poem

🐰 Hopping through locales with a mighty broom,
Five keys swept away from every room,
Confirmation dialogs fade to dust,
Plans flow cleaner—streamlined we trust,
A leaner codebase hops on with glee! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a Summary and Test Plan section with results, but is missing the Screenshots and Checklist sections required by the template. Add the Screenshots section (if applicable) and complete the Checklist section with checkboxes marked as appropriate for this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a no-apps subscription confirmation dialog from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-no-apps-subscription-dialog

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Apr 1, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks


Comparing codex/remove-no-apps-subscription-dialog (9160781) with main (3fd1ec7)

Open in CodSpeed

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 1, 2026

@riderx riderx marked this pull request as ready for review April 1, 2026 11:26
@riderx riderx merged commit d662343 into main Apr 1, 2026
17 checks passed
@riderx riderx deleted the codex/remove-no-apps-subscription-dialog branch April 1, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant