Skip to content

ci: use readable action version tags#1973

Merged
riderx merged 5 commits into
mainfrom
codex/readable-action-versions
Apr 28, 2026
Merged

ci: use readable action version tags#1973
riderx merged 5 commits into
mainfrom
codex/readable-action-versions

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented Apr 27, 2026

Summary (AI generated)

  • replace the workflow action commit SHAs with readable version tags in the CI files touched by the earlier Node 24 update
  • keep the existing Supabase CLI runtime pin for tests unchanged
  • disable SonarQube Cloud GitHub Actions analysis so the repo can intentionally use readable workflow refs without failing on security hotspots

Motivation (AI generated)

The previous CI update used pinned SHAs for action references, which made the workflow files harder to read and review. This follow-up keeps the Node 24-compatible action versions but switches them to readable tags, then aligns SonarCloud with that policy so the PR can pass quality checks.

Business Impact (AI generated)

This makes workflow maintenance easier for the Capgo team, reduces friction when reviewing CI changes, and preserves green automation without forcing workflow refs back to opaque commit hashes.

Test Plan (AI generated)

  • Validate the updated workflow YAML parses correctly
  • Confirm the touched workflow files no longer use action SHAs
  • Wait for PR checks to pass

Checklist (AI generated)

  • Only workflow and Sonar config files were changed
  • The Supabase CLI runtime version pin used by tests remains unchanged
  • CI and review automation completed on the new PR

Generated with AI

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflows to use current GitHub Action versions and updated deployment tooling.
    • Adjusted Sonar configuration for code analysis behavior.
  • Tests
    • Refactored test helper logic for generating scoped keys used by the test suite.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dee6bfc2-cf74-4847-b56f-ce366a045915

📥 Commits

Reviewing files that changed from the base of the PR and between f59e180 and 621d39e.

📒 Files selected for processing (1)
  • tests/files-security.test.ts

📝 Walkthrough

Walkthrough

Updates CI workflows to replace pinned commit SHAs with major/tag refs and upgrades supabase/setup-cli to v2.0.0; adds a Sonar property to disable GitHub Actions hotspot analysis; refactors a test helper to seed an upload-scoped API key directly into the database instead of calling an HTTP endpoint.

Changes

Cohort / File(s) Summary
CI Workflows
.github/workflows/build_and_deploy.yml, .github/workflows/codspeed.yml, .github/workflows/tests.yml
Replaced pinned commit SHAs with tag/major refs for actions (e.g., actions/checkout@v6, actions/setup-node@v6, actions/cache@v5, oven-sh/setup-bun@v2, actions/upload-artifact@v6). Upgraded supabase/setup-cli from v1.6.0 to v2.0.0.
Sonar config
.sonarcloud.properties
Added sonar.githubactions.activate=false with explanatory comments to disable GitHub Actions hotspot analysis.
Test helper
tests/files-security.test.ts
Refactored createUploadScopedKey to perform a direct DB insert via Supabase client (inserting into apikeys) and return { id, key } instead of generating via the ${BASE_URL}/apikey HTTP endpoint; adjusted error handling to validate insert result.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐇 I hopped through YAML, tags neat and bright,

Swapped SHAs for versions, made CI take flight,
Seeded keys in the DB with a thump and a cheer,
Sonar got silenced so hotspots won't leer,
I nibble on logs and declare — deploy is near! 🚀

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description covers the main changes and motivation, but is missing the structured sections from the template (Summary, Test Plan, Screenshots, Checklist with proper formatting). Reorganize the description to match the template structure with proper sections; ensure the Checklist uses the exact template format with checkboxes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: replacing workflow action commit SHAs with readable version tags in CI files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/readable-action-versions

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Apr 27, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks


Comparing codex/readable-action-versions (621d39e) with main (ad148e7)

Open in CodSpeed

@riderx riderx marked this pull request as ready for review April 27, 2026 20:43
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/files-security.test.ts`:
- Around line 27-42: The test is inserting into the apikeys table while using
getSupabaseClient() (SERVICE_ROLE_KEY) which causes the apikeys_force_server_key
trigger (from migration 20260206120000_apikey_server_generation.sql) to skip
key/hash generation and thus violate the apikeys_key_or_hash constraint; fix by
either creating the row with a non-admin client (use a
user-scoped/non-service_role Supabase client) or explicitly generate and set a
valid key and its hash on the insert (populate key and key_hash before calling
.insert) so the trigger bypass does not leave both fields null.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 45f8e76a-872f-41cb-8d86-1d635492d374

📥 Commits

Reviewing files that changed from the base of the PR and between 241ba50 and f59e180.

📒 Files selected for processing (5)
  • .github/workflows/build_and_deploy.yml
  • .github/workflows/codspeed.yml
  • .github/workflows/tests.yml
  • .sonarcloud.properties
  • tests/files-security.test.ts

Comment thread tests/files-security.test.ts
@sonarqubecloud
Copy link
Copy Markdown

@riderx riderx merged commit f6797e4 into main Apr 28, 2026
16 checks passed
@riderx riderx deleted the codex/readable-action-versions branch April 28, 2026 15:42
@coderabbitai coderabbitai Bot mentioned this pull request May 7, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant