fix: versions#1986
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThis PR introduces a custom background service startup script to replace an external GitHub Actions dependency, integrates it into CI workflows for Edge server, Cloudflare Workers, and Playwright tests, and bumps dependency versions across the stack (Capacitor, Capgo plugins, RevenueCat, frontend libraries, and tooling). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Review rate limit: 1/5 review remaining, refill in 44 minutes and 1 second. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/scripts/start-background-service.sh (1)
73-73: Pinwait-onin devDependencies instead of dynamic runtime fetchLine 73 uses
bunxto fetchwait-onat runtime, introducing an unnecessary registry dependency to a critical CI path. Since this script runs afterbun install --frozen-lockfile, addingwait-ontopackage.jsondevDependencies ensures deterministic, cached execution without network overhead during test runs.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/scripts/start-background-service.sh at line 73, The script currently invokes wait-on via bunx "wait-on@${wait_on_version}" which fetches at runtime; instead add a pinned wait-on entry to devDependencies in package.json (set the desired version from wait_on_version) and update the script to call the locally installed binary (e.g., "wait-on" from node_modules/.bin or via npx) using the same arguments (${wait_on_resources[@]}, ${wait_timeout_ms}, ${wait_interval_ms}); remove the dynamic bunx invocation and any reliance on wait_on_version at runtime so CI uses the frozen-lockfile cached dependency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/scripts/start-background-service.sh:
- Line 73: The script currently invokes wait-on via bunx
"wait-on@${wait_on_version}" which fetches at runtime; instead add a pinned
wait-on entry to devDependencies in package.json (set the desired version from
wait_on_version) and update the script to call the locally installed binary
(e.g., "wait-on" from node_modules/.bin or via npx) using the same arguments
(${wait_on_resources[@]}, ${wait_timeout_ms}, ${wait_interval_ms}); remove the
dynamic bunx invocation and any reliance on wait_on_version at runtime so CI
uses the frozen-lockfile cached dependency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9cee4d69-0aa9-4911-9017-cc42f42ff671
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.github/scripts/start-background-service.sh.github/workflows/tests.ymlios/App/CapApp-SPM/Package.swiftpackage.jsonplaywright.config.tssupabase/functions/deno.json
|


Summary
Test plan
Screenshots
Checklist
bun run lint:backend && bun run lint.accordingly.
my tests
Summary by CodeRabbit