Skip to content

fix(auth): simplify auth page framing#2040

Merged
riderx merged 1 commit into
mainfrom
codex/auth-ui-cleanup
May 6, 2026
Merged

fix(auth): simplify auth page framing#2040
riderx merged 1 commit into
mainfrom
codex/auth-ui-cleanup

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented May 6, 2026

Summary (AI generated)

  • Removed nested card framing from the login step content.
  • Changed auth footer panels into lightweight link rows across auth pages.
  • Removed extra captcha wrapper surfaces on register, forgot password, invitation, and account deletion auth flows.

Motivation (AI generated)

The auth screens were visually over-framed, especially login where the form sat inside multiple card-like containers. Simplifying the hierarchy makes the primary action clearer and keeps the auth family consistent.

Business Impact (AI generated)

Cleaner authentication screens reduce friction at sign-in, registration, password recovery, and invitation acceptance entry points.

Test Plan (AI generated)

  • Run bun lint
  • Run bun typecheck
  • Capture headless screenshots for /login, /register, and /forgot_password
  • Verify /login in dark mode with a headless screenshot

Generated with AI

Summary by CodeRabbit

  • Style
    • Refactored authentication page styling for buttons, panels, and cards across all authentication flows.
    • Updated login page navigation text and added a "don't have an account?" register link.
    • Simplified styling approach by replacing dynamic class bindings with explicit static styles.
    • Adjusted button appearance and link styling for improved visual consistency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cfeb295-a75f-44d2-9559-55fcadf5ddf9

📥 Commits

Reviewing files that changed from the base of the PR and between 4763e3a and db28ae7.

📒 Files selected for processing (7)
  • src/components/auth/pageStyles.ts
  • src/pages/delete_account.vue
  • src/pages/forgot_password.vue
  • src/pages/invitation.vue
  • src/pages/login.vue
  • src/pages/register.vue
  • src/pages/resend_email.vue

📝 Walkthrough

Walkthrough

Authentication styling constants are refactored to simplify class strings. Multiple authentication pages—delete account, forgot password, invitation, login, register, and resend email—remove dependencies on authInsetCardClass and adopt explicit static Tailwind class bindings. Login page also restructures navigation controls and messaging for account registration.

Changes

Authentication Styling Refactor

Layer / File(s) Summary
Style Constants
src/components/auth/pageStyles.ts
authPrimaryButtonClass, authSecondaryButtonClass, and authInlineLinkClass redefined with updated border-radius and gradient styling; authPanelClass and authInsetCardClass introduced as simplified constants replacing more verbose responsive definitions.
Page Component Updates
src/pages/delete_account.vue, src/pages/forgot_password.vue, src/pages/invitation.vue, src/pages/register.vue, src/pages/resend_email.vue
Imports updated to remove authInsetCardClass; captcha and card containers replaced with explicit static Tailwind classes (overflow-hidden, rounded-xl, border, etc.) instead of dynamic class bindings.
Login Page Restructuring
src/pages/login.vue
Button and card styling updated to match new class definitions; navigation controls refactored to remove arrow-prefix styling; new "don't have an account?" register link added to email step; go-back, register, and forgot-password controls consolidated within the credentials step panel.

Sequence Diagram(s)

No sequence diagram applicable. These changes are primarily styling and component-level wiring updates without new control flow across distinct system actors.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

A rabbit hops through style-sheets bright,
Refactoring classes left and right,
From auth-inset-card to overflow-hidden cheer,
The pages now dance—simpler each year! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main objective: simplifying authentication page framing by removing nested card structures and extra wrappers across auth pages.
Description check ✅ Passed The description covers all required template sections: Summary, Test Plan, and a partially completed Checklist with some items marked. However, Screenshots section is missing and most checklist items are unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/auth-ui-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented May 6, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks


Comparing codex/auth-ui-cleanup (db28ae7) with main (5b76c59)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (4763e3a) during the generation of this report, so 5b76c59 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@riderx riderx marked this pull request as ready for review May 6, 2026 11:45
@riderx
Copy link
Copy Markdown
Member Author

riderx commented May 6, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@riderx riderx merged commit 002beca into main May 6, 2026
38 checks passed
@riderx riderx deleted the codex/auth-ui-cleanup branch May 6, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant