Skip to content

[codex] Upload build env vars during init#2306

Merged
riderx merged 1 commit into
mainfrom
codex/build-init-ci-secrets
May 20, 2026
Merged

[codex] Upload build env vars during init#2306
riderx merged 1 commit into
mainfrom
codex/build-init-ci-secrets

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented May 20, 2026

Summary (AI generated)

  • Added build-init CI secret upload prompts after iOS and Android credentials are saved.
  • Added GitHub Actions secret upload through gh and GitLab CI/CD variable upload through glab.
  • Added setup guidance when the matching CLI is missing or not authenticated, with a retry prompt before continuing.
  • Added focused CI secret helper coverage and included it in the CLI test suite.

Motivation (AI generated)

Users who finish build init have local signing credentials, but still need the same env vars in their git hosting CI/CD provider to run cloud builds from pipelines. This adds an assisted path directly at the end of onboarding while preserving explicit confirmation before overwriting existing remote values.

Business Impact (AI generated)

This reduces setup friction for native cloud builds, especially for users configuring GitHub Actions or GitLab CI. Easier CI setup should improve activation for Capgo native builds and reduce support around manually copying large signing env vars.

Test Plan (AI generated)

  • bun run cli:check
  • Commit hook: bun run cli:build && vue-tsc --noEmit
  • Verified PR is opened as draft so CI can run before review-ready state.

Generated with AI

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Warning

Rate limit exceeded

@riderx has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 13 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5a0e6aef-8926-4e3e-8ead-592a9394c2b6

📥 Commits

Reviewing files that changed from the base of the PR and between 7712cd5 and 925ab1a.

📒 Files selected for processing (7)
  • cli/package.json
  • cli/src/build/onboarding/android/types.ts
  • cli/src/build/onboarding/android/ui/app.tsx
  • cli/src/build/onboarding/ci-secrets.ts
  • cli/src/build/onboarding/types.ts
  • cli/src/build/onboarding/ui/app.tsx
  • cli/test/test-ci-secrets.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/build-init-ci-secrets

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing codex/build-init-ci-secrets (925ab1a) with main (7712cd5)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@riderx riderx marked this pull request as ready for review May 20, 2026 11:29
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@riderx riderx merged commit fda8acf into main May 20, 2026
57 of 58 checks passed
@riderx riderx deleted the codex/build-init-ci-secrets branch May 20, 2026 13:36
WcaleNieWolny added a commit that referenced this pull request May 21, 2026
Following review of PR #2306, the build onboarding wizard now defers
GitHub Actions / GitLab CI secret upload until AFTER a build has been
successfully queued — rather than before. This prevents users from ending
up with orphan secrets in a repo whose build was never proven to work.

New ordering on both iOS and Android tracks:

  save credentials
    → ask-build
      ├─ user skips build  → exit (no secrets pushed)
      ├─ build request OK  → detecting-ci-secrets (if entries) → … → exit
      └─ build request err → exit (no secrets pushed)

All ci-secrets-* state transitions that previously fell back to ask-build
on skip / failure now route to build-complete instead, because by the
time those paths fire the build has already been dispatched.

bun.lock: workspace version bump from 7.104.0 → 7.108.2, picked up
mechanically by bun install (was stale on main).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant