fix(frontend): add subtle pending invite skip#2312
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a "skip pending invitations" feature to the onboarding flow. Users can defer resolving invitations by clicking a skip button, which persists the choice via sessionStorage and prevents the auth guard from redirecting back to the invitation page until the skip state is explicitly cleared. ChangesPending Invitation Skip
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/utils/pendingInviteSkip.ts`:
- Around line 3-26: canUseSessionStorage currently only checks for existence but
sessionStorage calls in rememberPendingInviteSkip, hasPendingInviteSkip, and
clearPendingInviteSkip can throw in restricted/privacy contexts; wrap
sessionStorage.getItem/setItem/removeItem calls in try/catch blocks, returning
safely (no-op in rememberPendingInviteSkip, false in hasPendingInviteSkip) on
error and optionally logging the error, and keep using
PENDING_INVITE_SKIP_STORAGE_KEY for the key; ensure canUseSessionStorage remains
a cheap existence check but do not rely on it to prevent exceptions from
sessionStorage operations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 66bbfeef-a34b-4186-9664-404b04e2b606
📒 Files selected for processing (4)
messages/en.jsonsrc/modules/auth.tssrc/pages/onboarding/invitation.vuesrc/utils/pendingInviteSkip.ts
Merging this PR will not alter performance
Comparing Footnotes
|
|



Summary (AI generated)
Motivation (AI generated)
Users reported they could not skip the pending invite decision. The flow still should nudge users toward joining the invited org, but it needs a clear fallback for users who want to continue without resolving the invite immediately.
Business Impact (AI generated)
This reduces onboarding frustration while keeping the intended invite-join path visually preferred, helping invited users continue without getting blocked.
Screenshots (AI generated)
Test Plan (AI generated)
bun lintbun typecheckgit diff --checkUX Notes (AI generated)
Summary by CodeRabbit