fix: use polymorphic_name in dependency_has_crm_id? to support STI su…#39
Open
BenjaminPachevie wants to merge 1 commit intomasterfrom
Open
fix: use polymorphic_name in dependency_has_crm_id? to support STI su…#39BenjaminPachevie wants to merge 1 commit intomasterfrom
BenjaminPachevie wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bclasses
Bug : dependency_has_crm_id? lookup avec dep.class.name, mais la row est stockée via l'association polymorphic (= polymorphic_name). Sur les STI, mismatch → dep toujours considérée manquante → boucle infinie buffer/flush.
Sur Blast : Trading::Operation dépend du profile (STI Users::NaturalProfile). La crm_synchronisation du profil est stockée avec resource_type = "Users::Profile", mais le lookup cherche "Users::NaturalProfile" → un PendingSync créé puis flush toutes les ~20s en boucle.
Fix : class.name → polymorphic_name. Test ajouté avec une STI subclass.