109 aws public fixes #234
Closed
109 aws public fixes #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enxebre
force-pushed
the
109-aws-public-fixes
branch
from
c448d08 to
9c2ec76
Compare
Contributor
Author
|
Fix #198 |
3 tasks
enxebre
force-pushed
the
109-aws-public-fixes
branch
from
dde0c39 to
bd93a87
Compare
enxebre
force-pushed
the
109-aws-public-fixes
branch
from
bd93a87 to
1f926bf
Compare
Member
|
Review of the code this LGTM. I think the docs could be improved but we can fix that after. Will give it a spin from my machine when I get a chance. |
Contributor
Author
|
There is an issue with mesos master redirecting to internal ip instead of public one when looking for the master lead. |
Member
|
@enxebre based on your comment, this still 'needs work' ? |
Contributor
Author
|
My comment is based on a quick manual test. It needs more testing first. |
Member
|
just did a provision and can confirm the issue exists here too. having a look |
Member
|
Closing this as I merged it into #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.