-
Notifications
You must be signed in to change notification settings - Fork 102
multi az support #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi az support #241
Conversation
|
this should solve #66 |
roles/consul/defaults/main.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the significance of adding the retry join?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consul was failing to elect a leader and then failing to show up as services in the UI. Adding this fixed it.
-retry-join - Similar to -join but allows retrying a join if the first attempt fails. This is useful for cases where we know the address will become available eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, I've seen consul consistently fail to cluster on bootstrap/apollo-launch.sh and every consul agent ends up with a cluster of one member, itself. We worked around it by defining consul_join but this is more flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we separate the consul retry join to a separate PR as that may resolve issues over in #198 and to avoid blocking on waiting for multi-az
|
Initial overview of the code looks ok. Can we also update the architecture diagram on the frontpage with this change? To do that you need to provision the cluster as normal, then login to visualops then there is an option to import from AWS (and you can import the running instances) which should create a diagram which you can view/edit |
|
couldnt add variables, as cant have dots in bash variables |
|
Closing in favour of #385 |
No description provided.