Skip to content

Conversation

@wallies
Copy link
Contributor

@wallies wallies commented May 25, 2015

No description provided.

@wallies
Copy link
Contributor Author

wallies commented May 25, 2015

this should solve #66

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the significance of adding the retry join?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consul was failing to elect a leader and then failing to show up as services in the UI. Adding this fixed it.
-retry-join - Similar to -join but allows retrying a join if the first attempt fails. This is useful for cases where we know the address will become available eventually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I've seen consul consistently fail to cluster on bootstrap/apollo-launch.sh and every consul agent ends up with a cluster of one member, itself. We worked around it by defining consul_join but this is more flexible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmbauer I've seen that too occassionally - I reported it over in #198. Looks like the consul related fixes here might address that too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we separate the consul retry join to a separate PR as that may resolve issues over in #198 and to avoid blocking on waiting for multi-az

@tayzlor
Copy link
Member

tayzlor commented May 26, 2015

Initial overview of the code looks ok. Can we also update the architecture diagram on the frontpage with this change?

To do that you need to provision the cluster as normal, then login to visualops then there is an option to import from AWS (and you can import the running instances) which should create a diagram which you can view/edit

@wallies
Copy link
Contributor Author

wallies commented Jun 3, 2015

couldnt add variables, as cant have dots in bash variables
export TF_VAR_zones.zone-0=${TF_VAR_zones.zone-0:-eu-west-1a}
export TF_VAR_zones.zone-1=${TF_VAR_zones.zone-1:-eu-west-1b}
export TF_VAR_zones.zone-2=${TF_VAR_zones.zone-2:-eu-west-1c}

@enxebre
Copy link
Contributor

enxebre commented Jul 14, 2015

Closing in favour of #385

@enxebre enxebre closed this Jul 14, 2015
@enxebre enxebre deleted the 66-multi-az-support branch July 15, 2015 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants