Skip to content

Run marathon as a docker container.#338

Merged
enxebre merged 1 commit intomasterfrom
marathon-container
Jun 30, 2015
Merged

Run marathon as a docker container.#338
enxebre merged 1 commit intomasterfrom
marathon-container

Conversation

@enxebre
Copy link
Contributor

@enxebre enxebre commented Jun 24, 2015

No description provided.

@enxebre enxebre mentioned this pull request Jun 24, 2015
Closed
@enxebre enxebre force-pushed the marathon-container branch from a21ca6c to 616634d Compare June 24, 2015 16:11
tayzlor
tayzlor reviewed Jun 25, 2015
View reviewed changes
roles/marathon/defaults/main.yml Outdated
Copy link
Member

@tayzlor tayzlor Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use https://github.com/mesosphere/marathon/releases/tag/v0.9.0-RC2

Copy link
Contributor Author

@enxebre enxebre Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need to rebuild packer images if we dont want it to go the internet though

@tayzlor
Copy link
Member

tayzlor commented Jun 25, 2015

This looks pretty good. after the comments and a squash it should be good to merge.

@tayzlor
Copy link
Member

tayzlor commented Jun 25, 2015

should we be removing the packer install scripts for the package in this PR too?

@tayzlor
Copy link
Member

tayzlor commented Jun 25, 2015

Lets also tag on master before this gets in

@enxebre enxebre mentioned this pull request Jun 25, 2015
Closed
@enxebre
Copy link
Contributor Author

enxebre commented Jun 25, 2015

I will tag, then I would keep the packages in packer and merge this PR. I'll create a follow up for removing the packages and update to lastest marathon image version.
#339

@enxebre
Copy link
Contributor Author

enxebre commented Jun 25, 2015

Also I noticed some perfomance issues when running marathon inside the container in vagrant that need to be investigated.

@enxebre enxebre force-pushed the marathon-container branch from 3f57818 to 3e1c76f Compare June 25, 2015 12:40
@enxebre enxebre force-pushed the marathon-container branch from 17edf89 to 24250d9 Compare June 30, 2015 12:32
enxebre added a commit that referenced this pull request Jun 30, 2015
@enxebre
Merge pull request #338 from Capgemini/marathon-container
d2ac763 
Run marathon as a docker container.
@enxebre enxebre merged commit d2ac763 into master Jun 30, 2015
@enxebre enxebre mentioned this pull request Jun 30, 2015
Closed
@enxebre enxebre deleted the marathon-container branch July 1, 2015 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enxebre @tayzlor