Skip to content

Run marathon as a docker container.#338

Merged
enxebre merged 1 commit intomasterfrom
marathon-container
Jun 30, 2015
Merged

Run marathon as a docker container.#338
enxebre merged 1 commit intomasterfrom
marathon-container

Conversation

@enxebre
Copy link
Contributor

@enxebre enxebre commented Jun 24, 2015

No description provided.

@enxebre enxebre mentioned this pull request Jun 24, 2015
@enxebre enxebre force-pushed the marathon-container branch from a21ca6c to 616634d Compare June 24, 2015 16:11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need to rebuild packer images if we dont want it to go the internet though

@tayzlor
Copy link
Member

tayzlor commented Jun 25, 2015

This looks pretty good. after the comments and a squash it should be good to merge.

@tayzlor
Copy link
Member

tayzlor commented Jun 25, 2015

should we be removing the packer install scripts for the package in this PR too?

@tayzlor
Copy link
Member

tayzlor commented Jun 25, 2015

Lets also tag on master before this gets in

@enxebre
Copy link
Contributor Author

enxebre commented Jun 25, 2015

I will tag, then I would keep the packages in packer and merge this PR. I'll create a follow up for removing the packages and update to lastest marathon image version.
#339

@enxebre
Copy link
Contributor Author

enxebre commented Jun 25, 2015

Also I noticed some perfomance issues when running marathon inside the container in vagrant that need to be investigated.

@enxebre enxebre force-pushed the marathon-container branch from 17edf89 to 24250d9 Compare June 30, 2015 12:32
enxebre added a commit that referenced this pull request Jun 30, 2015
Run marathon as a docker container.
@enxebre enxebre merged commit d2ac763 into master Jun 30, 2015
@enxebre enxebre deleted the marathon-container branch July 1, 2015 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants