Skip to content

Conversation

@daniele-zurico
Copy link
Contributor

@daniele-zurico daniele-zurico commented Jul 1, 2022

It will close: #298 #298 #303

@testing-library/user-event:

BEFORE:

  test('request support action',() => {
    render(<SupportSection requestSupport={requestSupport} />);

    const button = screen.getByRole('button');

    userEvent.click(button);

    expect(requestSupport).toHaveBeenCalled();
  });

AFTER:

  test('request support action', async () => {
    const user = userEvent.setup();
    
    render(<SupportSection requestSupport={requestSupport} />);

    const button = screen.getByRole('button');

    await user.click(button);

    expect(requestSupport).toHaveBeenCalled();
  });

@daniele-zurico daniele-zurico requested a review from Ibabalola July 1, 2022 15:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #305 (f21241d) into release/0.5 (61b257e) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release/0.5      #305   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               42        42           
  Lines              909       909           
  Branches           333       333           
=============================================
  Hits               909       909           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b257e...f21241d. Read the comment docs.

@Ibabalola Ibabalola merged commit ff4bf30 into release/0.5 Jul 7, 2022
@daniele-zurico daniele-zurico deleted the feature/upgrade-testing-library branch March 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants