Skip to content

Conversation

@mriverre8
Copy link
Contributor

Issue #276

@daniele-zurico daniele-zurico changed the base branch from main to release/0.5 July 8, 2022 09:24
@daniele-zurico
Copy link
Contributor

@mriverre8 thanks for your PR ... unfortunately looks like some tests are missing:

Autocomplete.tsx      |     100 |    97.22 |     100 |     100 | 284

I suggest to run
yarn test
locally and under the test coverage folder you'll find an index file (/coverage/lcov-report/index.html).
Open with your browser and you'll see which test you missing

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #307 (9f3c605) into release/0.5 (fa5c049) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release/0.5      #307   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               42        43    +1     
  Lines              910       949   +39     
  Branches           334       357   +23     
=============================================
+ Hits               910       949   +39     
Impacted Files Coverage Δ
src/formInput/FormInput.tsx 100.00% <ø> (ø)
src/autocomplete/Autocomplete.tsx 100.00% <100.00%> (ø)
src/autocomplete/ResultList.tsx 100.00% <100.00%> (ø)
src/common/utils/clientOnly.tsx 100.00% <100.00%> (ø)
src/formSelect/FormSelect.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5c049...9f3c605. Read the comment docs.

@daniele-zurico
Copy link
Contributor

@mriverre8 you PR has also conflicts that need to be solved:

src/autocomplete/Autocomplete.tsx
stories/Autocomplete/Styled.stories.mdx

@daniele-zurico
Copy link
Contributor

daniele-zurico commented Jul 19, 2022

@mriverre8 I know this PR is not still merged, despite you correctly implementing the ticket, but I'm changing the initial code to make it smarter. The idea is to let the component understand on his own if javascript is enabled or not instead to let the user pass extra properties (isProgressiveEnhancment)

let hydrated = useHydrated();

@daniele-zurico daniele-zurico changed the title Feature/autocmplete non js Feature/autocomplete non js Jul 20, 2022
@daniele-zurico daniele-zurico requested a review from Ibabalola July 20, 2022 14:17
@daniele-zurico daniele-zurico merged commit 6c3e881 into release/0.5 Jul 20, 2022
@daniele-zurico daniele-zurico deleted the feature/autocmplete-nonJs branch March 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants