-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/autocomplete non js #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mriverre8 thanks for your PR ... unfortunately looks like some tests are missing: I suggest to run |
Codecov Report
@@ Coverage Diff @@
## release/0.5 #307 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 42 43 +1
Lines 910 949 +39
Branches 334 357 +23
=============================================
+ Hits 910 949 +39
Continue to review full report at Codecov.
|
|
@mriverre8 you PR has also conflicts that need to be solved: |
|
@mriverre8 I know this PR is not still merged, despite you correctly implementing the ticket, but I'm changing the initial code to make it smarter. The idea is to let the component understand on his own if javascript is enabled or not instead to let the user pass extra properties (isProgressiveEnhancment) let hydrated = useHydrated(); |
Issue #276