Skip to content

Conversation

@alexwbbr
Copy link
Collaborator

Hides the error element in the ErrorMessage component if the text property is not present

#315

@alexwbbr alexwbbr added this to the 0.5 milestone Jul 15, 2022
@alexwbbr alexwbbr requested a review from daniele-zurico July 15, 2022 12:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #317 (1fb95b9) into release/0.5 (c8ae4d6) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release/0.5      #317   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               42        42           
  Lines              910       916    +6     
  Branches           334       335    +1     
=============================================
+ Hits               910       916    +6     
Impacted Files Coverage Δ
src/common/components/ErrorMessage.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ae4d6...1fb95b9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't print/render the error span if text value in the error prop is null/undefined/falsy

4 participants