-
Notifications
You must be signed in to change notification settings - Fork 6
fix: updates checkbox/radio to show conditional with nojs #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updates checkbox/radio to show conditional with nojs #325
Conversation
de63a80 to
e6b10c6
Compare
Codecov Report
@@ Coverage Diff @@
## release/0.5 #325 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 43 43
Lines 955 961 +6
Branches 361 361
=============================================
+ Hits 955 961 +6
Continue to review full report at Codecov.
|
|
@alexwbbr I gave this a test run and I noted 2 issues:
|
|
@brightpixels I have changed the rendering of the conditional which should have fixed the issue where it was no longer being displayed with JS enabled. As for the styling currently there are already lots of classNames you can pass down to the conditional to style it anyway you want which can be defined in the conditional properties section. |
package.json
Outdated
| "author": "Capgemini UK", | ||
| "license": "MIT", | ||
| "version": "0.5.0-beta-3", | ||
| "version": "0.5.0-beta-4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please change to beta-5 and update the documentation?
Updates the common checkbox and radio component to show the conditional when JS is off
#309