Skip to content

Feature/stem ai integration#289

Merged
halinhtvn3a merged 7 commits intodevfrom
feature/STEM-ai-integration
Dec 22, 2025
Merged

Feature/stem ai integration#289
halinhtvn3a merged 7 commits intodevfrom
feature/STEM-ai-integration

Conversation

@halinhtvn3a
Copy link
Copy Markdown
Contributor

This pull request introduces several improvements and fixes across the identity service, focusing on user activation logic, organization user queries, cookie handling for logout, and configuration updates. The most significant changes are enhancements to user filtering and paging in organization queries, improved user activation checks, and security-related adjustments to cookie management.

Organization User Query Improvements:

  • Refactored the user retrieval logic in GetOrganizationUsersByOrganizationIdQueryHandler to fetch all distinct user IDs before applying filters and paging, ensuring accurate filtering and paging results. Updated all related variable names and logging for clarity.
  • Updated group filtering to correctly handle cases where GroupId is zero, treating it as a request for users without a group.
  • Changed paging logic to apply after filtering and grouping users, ensuring that the returned page contains only filtered users. Updated the returned total user count to reflect the filtered set.

User Activation Logic:

  • Modified the user activation step in AcceptInvitationCommandHandler to activate users only if their status is neither Active nor Deleted, preventing unnecessary state changes.

Security and Configuration Updates:

  • Improved logout cookie handling in AccountController to always set the Secure flag and dynamically set the cookie domain for secure requests, enhancing security and compatibility with reverse proxies.
  • Updated notification API configuration to use the correct identity service domain (identity instead of identity-api) for both the issuer and service URL.

Minor Fixes:

  • Fixed property mapping in UserGrpcService to use FirstName and LastName instead of GivenName and FamilyName when constructing GrpcUserResponse.

Modified user activation to prevent re-activation of already active or deleted users in AcceptInvitationCommandHandler. Updated AccountController to always set cookies as secure and set the domain based on request security.
@halinhtvn3a halinhtvn3a merged commit 6d8f102 into dev Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant