Feature/stem ai integration#289
Merged
halinhtvn3a merged 7 commits intodevfrom Dec 22, 2025
Merged
Conversation
…tone-STEMify/STEMify-Backend into feature/STEM-ai-integration
Modified user activation to prevent re-activation of already active or deleted users in AcceptInvitationCommandHandler. Updated AccountController to always set cookies as secure and set the domain based on request security.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the identity service, focusing on user activation logic, organization user queries, cookie handling for logout, and configuration updates. The most significant changes are enhancements to user filtering and paging in organization queries, improved user activation checks, and security-related adjustments to cookie management.
Organization User Query Improvements:
GetOrganizationUsersByOrganizationIdQueryHandlerto fetch all distinct user IDs before applying filters and paging, ensuring accurate filtering and paging results. Updated all related variable names and logging for clarity.GroupIdis zero, treating it as a request for users without a group.User Activation Logic:
AcceptInvitationCommandHandlerto activate users only if their status is neither Active nor Deleted, preventing unnecessary state changes.Security and Configuration Updates:
AccountControllerto always set theSecureflag and dynamically set the cookie domain for secure requests, enhancing security and compatibility with reverse proxies.identityinstead ofidentity-api) for both the issuer and service URL.Minor Fixes:
UserGrpcServiceto useFirstNameandLastNameinstead ofGivenNameandFamilyNamewhen constructingGrpcUserResponse.