LandTraitChanges: add extra for SpellAbility by Type Change (Layer 4) #9609
+210
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tool4ever
reviewed
Jan 25, 2026
Hanmac
force-pushed
the
landTypeTraitChanges
branch
from
3c36ffc to
fba34b3
Compare
tool4ever
approved these changes
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9532, #9583
Uses an extra class for CardTraitChanges by Type Change (Layer 4)
it also uses new
CardTraitBase::isManaAbilityfor "remove non mana abilities"(so it should keep the triggered ones)
for the new LandTraitChanges in CardState, i use #9570 to have the SpellAbilities in an Enum Map
(that somewhat fixes that the BasicLand Ability might be on the wrong state for a DFC?)