feat: finality-aleph error handling#31
Merged
mike1729 merged 7 commits intoCardinal-Cryptography:mainfrom Mar 25, 2021
Merged
Conversation
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
# Description This PR fixes failures of below PRs * [ Weekly test featurenets create (short session, branch) #29 ](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9184709772/job/25257716527) * [ Nightly pipeline e2e tests on featurenet #252 ](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9182597897/job/25251809531) * [ Weekly test featurenets create (short session, full sha) #29 ](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9184881192) * [ Weekly test featurenets create (short session, tag) #31 ](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9185009358/job/25258262062) Also, this PR shifts sync non-pruned snapshots tests by 2 hours so that they end by 7 am CEST time. ## Type of change Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) # Checklist: The above tests passes: * https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9185929615 * https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9186216412 * https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9185932129 * https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9186357810 Below passes (no regressions): * https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9186005787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in error handling where needed, sets the Type Error in the environment, and also swaps unwraps for expects.