Skip to content

A0-2005: Create yamllint configuration for linting YAML files in .github directory#943

Merged
Kosiare merged 34 commits intomainfrom
A0-2005-gha-yamllint
Mar 2, 2023
Merged

A0-2005: Create yamllint configuration for linting YAML files in .github directory#943
Kosiare merged 34 commits intomainfrom
A0-2005-gha-yamllint

Conversation

@Kosiare
Copy link

@Kosiare Kosiare commented Feb 23, 2023

Description

Additional workflow with YAML Lint. It triggers only when some .yml or .yaml files are modified in the .github directory.
It lints only those files that were changed in comparison to the PRs base branch. Therefore if some files won't pass this check, it won't block any PR if that PR doesn't include any changes for those files.

Changes:

  • YAML Lint workflow
  • .yamllint - yamllint configuration file. Docs with explanations and examples for every rule in this file: Linting rules

In the next PR, I'll modify every .yaml and .yml file to follow all those rules.

Type of change

  • New feature (non-breaking change which adds functionality)

@Kosiare Kosiare self-assigned this Feb 23, 2023
@Kosiare Kosiare marked this pull request as ready for review February 24, 2023 19:09
@Kosiare Kosiare force-pushed the A0-2005-gha-yamllint branch 2 times, most recently from b7bd4ee to a4c0cb4 Compare February 24, 2023 19:39
@Kosiare Kosiare force-pushed the A0-2005-gha-yamllint branch from a4c0cb4 to 5e30c0c Compare February 24, 2023 19:39
@Kosiare Kosiare force-pushed the A0-2005-gha-yamllint branch from a1e025f to 4c7d446 Compare March 1, 2023 19:40
@Kosiare Kosiare requested review from a user, Marcin-Radecki and fbielejec March 1, 2023 20:24
Copy link
Contributor

@Marcin-Radecki Marcin-Radecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much approve.

Copy link
Contributor

@fbielejec fbielejec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be annoying but probably also necessary :)

@Kosiare Kosiare merged commit 57566a3 into main Mar 2, 2023
@Kosiare Kosiare deleted the A0-2005-gha-yamllint branch March 2, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants