Skip to content

Run on self-hosted runner#948

Merged
pmikolajczyk41 merged 10 commits intosnarkelingfrom
liminal/ci-runner
Mar 2, 2023
Merged

Run on self-hosted runner#948
pmikolajczyk41 merged 10 commits intosnarkelingfrom
liminal/ci-runner

Conversation

@pmikolajczyk41
Copy link
Contributor

@pmikolajczyk41 pmikolajczyk41 commented Feb 27, 2023

Follow #903

@fbielejec
Copy link
Contributor

fbielejec commented Feb 27, 2023

  1. Follow A0-1803: Switch to self-hosted runners  #903
  2. Remove unused workflow files

There are quite a few workflow files removed - can you explain why? They are not used on this branch but surely they are used on the master, where it eventually be merged?

@pmikolajczyk41
Copy link
Contributor Author

@fbielejec I've removed them just to clear the directory from unmaintained files - I wanted to keep only the files that are actually used and we care about; once we merge into master, they will be restored

@fbielejec
Copy link
Contributor

@fbielejec I've removed them just to clear the directory from unmaintained files - I wanted to keep only the files that are actually used and we care about; once we merge into master, they will be restored

I don't understand this argument - what do you mean unmaintained? All these files are under version control and have changes ~3 days from now (https://github.com/Cardinal-Cryptography/aleph-node/tree/main/.github/workflows). You should be merging the changes, not removing these files

@pmikolajczyk41
Copy link
Contributor Author

pmikolajczyk41 commented Feb 27, 2023

they are not maintained nor used on snarkeling branch; but it's not a big deal, I can restore them - they'll be just rubbish files until mergin into main

@fbielejec
Copy link
Contributor

fbielejec commented Feb 27, 2023

they are not maintained nor used on snarkeling branch; but it's not a big deal, I can restore them - they'll be just rubbish files until mergin into main

that's not how version-control is supposed to work - if you remove them there will be merge conflicts. Now you're relying on a weakest link, which is human memory - what if it's not you merging these changes? how will she know what is the right way to resolve?

There is a perfectly fine way to avoid running workflows in these scenarios:

on:
  push:
    paths:

@pmikolajczyk41 pmikolajczyk41 merged commit c940eb2 into snarkeling Mar 2, 2023
@pmikolajczyk41 pmikolajczyk41 deleted the liminal/ci-runner branch March 2, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants