Open
Conversation
dmadisetti
reviewed
Jul 22, 2022
Contributor
dmadisetti
left a comment
dmadisetti
left a comment
There was a problem hiding this comment.
Cool, hope you get working soon
src/app-frame.js
Outdated
| window.$ = $; | ||
|
|
||
| import('./scripts/frame.js'); | ||
| import infiniteLoopDetector from './scripts/makeitsafe.js'; |
Contributor
There was a problem hiding this comment.
This should be in frame.js or before the frame.js import (préférable the first)
src/scripts/frame.js
Outdated
| }; | ||
| try { | ||
| console.log("yoyoy"); | ||
| code = infiniteLoopDetector.wrap(code) |
Contributor
There was a problem hiding this comment.
Suggestion, take this out the try
| eval(code); | ||
| } catch (e) { | ||
| if (e.type === 'InfiniteLoopError') { | ||
| console.log('infinite loop detected') |
Contributor
There was a problem hiding this comment.
console.err should print to the page
… if code works and couldnt get import working
Contributor
|
What's the error you're getting? |
Contributor
|
Patching this into one of my branches to test out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't work yet
can't get the infiniteLoopDetector object imported into editframe.js