Skip to content

Remove contextual menu when right clicking on non-post rows in the posts view.#38

Open
Tanner wants to merge 2 commits intoCarterA:masterfrom
Tanner:contextual-edit-crash
Open

Remove contextual menu when right clicking on non-post rows in the posts view.#38
Tanner wants to merge 2 commits intoCarterA:masterfrom
Tanner:contextual-edit-crash

Conversation

@Tanner
Copy link
Copy Markdown

@Tanner Tanner commented Sep 5, 2013

The actual cause of the crash is when "Edit Post" is clicked. However,
none of the menu items apply to an empty row, thus don't bother showing
the menu.

No further code added other than making TBPostsViewController a NSMenuDelegate and handling menuNeedsUpdate.

I'm unsure if hiding all the items is the "correct" solution, but it works.

The actual cause of the crash is when "Edit Post" is clicked. However,
none of the menu items apply to an empty row, thus don't bother showing
the menu.
@CarterA
Copy link
Copy Markdown
Owner

CarterA commented Sep 5, 2013

This looks good, but I'd appreciate it if you would remove the extra whitespace in the method you added. See my note on your other recent PR for details.

@Tanner
Copy link
Copy Markdown
Author

Tanner commented Sep 5, 2013

No problemo! I removed some whitespace. I am unsure if the coding style for single line conditionals/loops in relation for braces (same line, separate line, none if only one line, etc…). Let me know what style you would like and I can make the appropriate changes (if any).

@GeorgeWS
Copy link
Copy Markdown
Collaborator

GeorgeWS commented Sep 6, 2013

Sounds like it's time for @CarterA to write a coding style guide! Too bad he's not the kind of person who would enjoy writing a coding style guide.

...Wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants