Remove contextual menu when right clicking on non-post rows in the posts view.#38
Open
Tanner wants to merge 2 commits intoCarterA:masterfrom
Open
Remove contextual menu when right clicking on non-post rows in the posts view.#38Tanner wants to merge 2 commits intoCarterA:masterfrom
Tanner wants to merge 2 commits intoCarterA:masterfrom
Conversation
The actual cause of the crash is when "Edit Post" is clicked. However, none of the menu items apply to an empty row, thus don't bother showing the menu.
Owner
|
This looks good, but I'd appreciate it if you would remove the extra whitespace in the method you added. See my note on your other recent PR for details. |
Author
|
No problemo! I removed some whitespace. I am unsure if the coding style for single line conditionals/loops in relation for braces (same line, separate line, none if only one line, etc…). Let me know what style you would like and I can make the appropriate changes (if any). |
Collaborator
|
Sounds like it's time for @CarterA to write a coding style guide! Too bad he's not the kind of person who would enjoy writing a coding style guide. ...Wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual cause of the crash is when "Edit Post" is clicked. However,
none of the menu items apply to an empty row, thus don't bother showing
the menu.
No further code added other than making TBPostsViewController a NSMenuDelegate and handling menuNeedsUpdate.
I'm unsure if hiding all the items is the "correct" solution, but it works.