This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Add emscripten support #509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtehver
reviewed
Jul 26, 2022
Contributor
mtehver
left a comment
mtehver
left a comment
There was a problem hiding this comment.
I have added some suggestions and few places that need addressing.
- Used request.method instead of 'GET' in network/HTTPClientEmscriptenImpl.cpp. - Set headers to http request in network/HTTPClientEmscriptenImpl.cpp. - Used 'std::atomic<bool>' type for '_needRedraw' variable in MapView. - Set alpha, depth and stencil to 1. (SDK uses alpha channel, depth buffer and stencil buffer.) (Fixed 3d model transparency issue.) - Removed double click handler. - Added additional EmscriptenInput namespace in ui/EmscriptenInput.(h/cpp) - Changed raster map url with cartocdn.
Added text and popup example. Implemented OffscreenCanvas usage. Added vector tile event listener example.
Author
|
@mtehver, I implemented your suggestions and updated the demo site. Additionally, the listeners now work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #510