Skip to content

The MSL switch profile#484

Merged
CastagnaIT merged 11 commits intomasterfrom
msl_switch
Feb 24, 2020
Merged

The MSL switch profile#484
CastagnaIT merged 11 commits intomasterfrom
msl_switch

Conversation

@CastagnaIT
Copy link
Owner

@CastagnaIT CastagnaIT commented Feb 22, 2020

Check if this PR fulfills these requirements:

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Feature change (non-breaking change which change behaviour of an existing functionality)
  • Improvement (non-breaking change which improve functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

After more o less 8 hours of testing and network flow analisys and source code analysis
I was able to get the missing key of this project!

🎉🎉✨🎊🎁 The MSL switch profile! 🎉🎉✨🎊🎁

That's a big stone that's always been missing

This solves many very very old problems, from the first version of this addon (13.x) developed by asciidisco

Now being able to run this MSL switch, we can make MSL requests using actually the selected user profile!

What solves:

  • The availability of audio languages will be correct, no more missing languages
  • The availability of subtitle languages will be correct, no more missing languages
  • Now requests from Kid profiles can actually be executed correctly
  • Solved the problems of age limits set in the main profile but not in the others, that caused errors like video not available
  • You can communicate the watched status of the watched videos in each profile!

Ref.
#385
#366

Due to major refactor to the code i could not make separate commits,
so to better understand the changes i will try to divide the refactor and the implementation into two commits

Due to the complexity of this implementation there will certainly be some errors overlooked, also because i don't have testers able to support me

Unresolved problem:
Progress sent by Kodi are not displayed on android, but only on the website,
seem that is the same problem of not updated continue watching list

In case of Feature change / Breaking change:

Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

@CastagnaIT CastagnaIT added the WIP PR that is still being worked on label Feb 22, 2020
@CastagnaIT CastagnaIT force-pushed the msl_switch branch 2 times, most recently from 8a547ef to 2ab4bc1 Compare February 22, 2020 10:39
@CastagnaIT CastagnaIT added Testers needed To resolve this issue other testers are required and removed WIP PR that is still being worked on labels Feb 22, 2020
@CastagnaIT
Copy link
Owner Author

CastagnaIT commented Feb 22, 2020

i need a volunteer to do a tests
if someone wants to run some tests, remember to also examine the log for errors
the tests will have to be carried out on several profiles, even with different languages
Instruction: https://github.com/CastagnaIT/plugin.video.netflix/wiki/Sync-watched-status-with-Netflix

I suggest a backup of your previous version

-install Kodi from scratch
-Install this plugin.video.netflix_0.16.4_20200223_test2.zip
-Without login, open addon settings and on expert setting set debug verbose
-Remember to enable Kodi debug

If you want to provide a log here do these steps:
-Reboot Kodi (in order to create a clean log)
-Open addon
-Select a profile (let me know is you select the main owner profile or others)
-Enable the sync of watched status
-Open a list and play a video
-Watch at least 4 minutes of video
-Press stops and wait at least 30 seconds (network operations will be completed)
-Provide the log

@Gelion01
Copy link

kodi.log
Here you are.

@CastagnaIT
Copy link
Owner Author

Thank you!

@Gelion01
Copy link

kodi_sync_main.log
kodi_sync_other.log
kodi_sync_other2.log

I did the test with 2 non-main accounts, because on the first "other" account there was parallel playback on another device. I didn't want to screw up any results with this.

I don't know whether you are aware of this, but the continue watching playlist still doesn't get updated through the sync (TV series already in the list get updated internally, but they don't move up the list). Also, through the netflix android app, you're not able to see the progress already made when you are watching a movie. When you play it, you start off where you left with kodi. TV series are displayed differently because of their seasons. There is always a progress bar displayed at the episodes.
Within the browser, this isn't a problem, because a progress bar is always being displayed, no matter whether the movie is in the continue watching list or not.
I really appreciate your work and hope that I can be a little bit of a help with this.

@CastagnaIT
Copy link
Owner Author

don't know whether you are aware of this, but the continue watching playlist still doesn't get updated

Answer here: https://github.com/CastagnaIT/plugin.video.netflix/wiki/Sync-watched-status-with-Netflix

in relation to netflix android app,
i think the problem of not being able to visualize the progress made with Kodi is due to the same problem of continue watching list

there's no documentation on how these things work the only way is to experiment in the field
now that things are working better, i can try to reuse the refreshlolomo path again

Fixing this last thing is the only thing missing to have everything working almost perfectly

@CastagnaIT CastagnaIT removed the Testers needed To resolve this issue other testers are required label Feb 24, 2020
@CastagnaIT CastagnaIT merged commit 424eea6 into master Feb 24, 2020
@CastagnaIT CastagnaIT deleted the msl_switch branch February 24, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments