Skip to content

Feature/round vectors after scaling #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cazka merged 2 commits into from
Oct 4, 2022
Merged

Feature/round vectors after scaling #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a0bb3
Add rounding after scaling
Cazka Oct 4, 2022
65d9b6b
rounding here is not needed anymore
Cazka Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/apis/arena.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Arena {
ratio,
scaling.screenToCanvas(new Vector(_window.innerWidth, _window.innerHeight))
);
const arenaSize = Vector.round(scaling.toArenaUnits(arenaDim));
const arenaSize = scaling.toArenaUnits(arenaDim);
this.#size = arenaSize.x;
}, 16);
}
Expand Down
4 changes: 2 additions & 2 deletions src/apis/scaling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class Scaling {
* @returns {Vector} The vector in arena units
*/
toArenaUnits(v: Vector): Vector {
return Vector.unscale(this.#scalingFactor, v);
return Vector.round(Vector.unscale(this.#scalingFactor, v));
}

/**
Expand All @@ -61,7 +61,7 @@ class Scaling {
* @returns {Vector} The vector in canvas units
*/
toCanvasUnits(v: Vector): Vector {
return Vector.scale(this.#scalingFactor, v);
return Vector.round(Vector.scale(this.#scalingFactor, v));
}

/**
Expand Down