Fix crash when no objects are found within a score-all chunk #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/cpa-score-all-indexerror-tuple-index-out-of-range/57856/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described on the forum, some users reported that the Score All function crashed with some databases.
Score All runs by breaking the objects list up into reasonably sized segments based on the image number. This crash happened when a particular segment (e.g. ImageNumbers 50-60) contained no objects. The fix should be simply continuing if there's no data to work with.
I've also removed the redundant 'AND 1=1' condition which was being added to queries whenever there was no filter active, because I see no reason to be doing this.