Issues/310 (visualization of 3D datasets in CPA) #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geviewer, prproperties, sortbin, trainingset, though current behavior is just to have the z level for the first object queried
…ow tiles will appear with object's center z, BUT then when doubleclicking, the full image will be at the first object's z
…ile, imagetools, properties, tilecollection Rather than relying on having a Z coordinate, scripts now rely on being processed as 3D. Also cleaned up some code in line with David's suggestions.
…reading large images
Changed dbconnect, imagereader, imagetile, and imagetools to fix issues with fetching tiles in Image Gallery and 3D datasets In imagereader.py, allow for image set z at middle value for that image. In imagetile.py, Fixed double click issue where opening an image full-size from the image gallery caused a crash if the dataset was 3d (fixed by not grabbing object coordinates first) and passing if the obkey is -1. Removed a stray print statement in dbconnect.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310 by allowing visualization of image stacks depending on the mid-point of a particular object or image in z.
Changed classifier, image gallery, and image reading/tile fetching functions to allow 3D images to be read with a specific z plane depending on the midpoint of an object or image in z.
Tested w/ 2D (translocation) and 3D (monolayer) datasets.
This pull request is more up to date than #312 (I couldn't change this because a collaborator may need to use that specific version). Specifically, this PR fixes issues with Image Gallery that were present in #312. To my knowledge, there aren't further bugs that need squashing in this version.