Skip to content

Conversation

@hinerm
Copy link
Contributor

@hinerm hinerm commented Sep 21, 2023

Required for newer PyImageJ releases (1.4.1) until we have a release with
imagej/pyimagej@a1861b6 merged.

Closes #218

Required for newer PyImageJ releases (1.4.1) until we have a release
with
imagej/pyimagej@a1861b6
merged.

Closes CellProfiler#218
@bethac07
Copy link
Member

Awesome, thanks for the quick fix!

Quick q just before pulling - will this change hurt for later versions, or will it just be purely defensive there? Just wondering if we will need/want to set our pyimageJ pin to a particular version.

@hinerm
Copy link
Contributor Author

hinerm commented Sep 21, 2023

Quick q just before pulling - will this change hurt for later versions, or will it just be purely defensive there?

Should just be defensive.. most of the time it should do nothing, and should only help if using a pyimagej version that can return Java string names on DataArrays. I am happy to update it to be more defensive if we discover a need at any point.

I think we would only need to pin to a version (or set a minimum) of pyimagej if we want to remove this hack when the next pyimagej version is released.

@bethac07 bethac07 merged commit d72a608 into CellProfiler:master Sep 21, 2023
@bethac07
Copy link
Member

I think we would only need to pin to a version (or set a minimum) of pyimagej if we want to remove this hack when the next pyimagej version is released.

Cool, you let me know if you'd like that to happen then, but for now, will pull!

DavidStirling pushed a commit to DavidStirling/CellProfiler-plugins that referenced this pull request Sep 25, 2023
Required for newer PyImageJ releases (1.4.1) until we have a release
with
imagej/pyimagej@a1861b6
merged.

Closes CellProfiler#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues running RunImageJScript plugin - pyimageJ version?

2 participants