feat(enums): update enum for notification refactor node settings page#734
Merged
Johnetordoff merged 1 commit intofeature/notifications-refactorfrom Oct 30, 2025
Merged
Conversation
Collaborator
Author
|
Dear reviewers, this might be the only thing that needs changing in the FE if that's the case we may want to make this backward compatible to simplify the NR release, add thoughts about that, because obviously this breaks current OSF versions. |
Contributor
|
Probably we should make a notifications refactor branch for angular osf. |
Contributor
|
Done |
Author
|
@brianjgeiger this PR in conjunction with CenterForOpenScience/osf.io#11405 seem to make all issues go away. But I don't think staging1 is set to this the new branch. I think that still needs to be done to get back to QA. |
Contributor
|
Staging is on the new branch, but this isn't merged yet. |
brianjgeiger
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Match the existing notification values to the new notification refactor
Summary of Changes
to
Screenshot(s)
No visible changes
Side Effects
QA Notes