[ENG-3962] Fix issues with Resource (A)VOLs#10024
Merged
jwalz merged 2 commits intoAug 16, 2022
Merged
Conversation
jwalz
changed the title
brianjgeiger
approved these changes
Aug 15, 2022
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
That is much cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resources were not surfacing the
resource_typein Anonymized contexts, and theselflink for the Resources omitted the VOL, potentially leaking information for public registrations.See:
https://www.notion.so/cos/Resource-self-link-does-not-inherit-VOL-key-723d274267cb4ad18768a2b6378cf6fe
https://www.notion.so/cos/resource-type-not-serialized-in-AVOLs-c09186bfee9e4b04b3ce2a02b22d51d8
Changes
resource_typeto thenonanonymized_fieldsfor a ResourceLinkFieldsto always append an vol key toselflinksQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-3962