Fix DOI Updating#10030
Merged
jwalz merged 6 commits intoAug 22, 2022
Merged
Conversation
| return self.create_identifier(node, category) | ||
| logger.info('TEST ENV: DOI built but not minted') | ||
|
|
||
| return {'doi': doi_value, 'metadata': metadata} |
Contributor
There was a problem hiding this comment.
nit: it would be nice to have consistency with the crossref client with these return values.
brianjgeiger
approved these changes
Aug 22, 2022
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Looks good. A little surprise about a comparison working, but if that's all fine, this seems good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DOI update was failing validation due to the inclusion of duplicates. It also wasn't excluding deleted Resources or non-final Resources, and there were some lingering issues with the existing Datacite update logic to be resolved.
Changes
relatedIdentifierone timerelatedIdentifiersDataciteClient.update_identifierQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket