[ENG-9127] Contributor page of components should offer option to import contributors from parent project.#11376
Conversation
mkovalua
changed the title
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Overall looks good, but could use a test or two.
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
You have some extra things in this PR that shouldn't be there. notifications/tasks.py , osf/email/init.py, osf/migrations/0034_abstractnode_keenio_read_key.py, and https://github.com/CenterForOpenScience/osf.io/pull/11376/files#diff-4b31ed2d6164722b2fcdd35dd56c11fa7cced0a4753944e56fc1807176593de3R479
mkovalua
force-pushed
the
feature/ENG--9127
branch
from
1ca2846 to
bbc065e
Compare
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
One question about a test oddity. We're having trouble running one of our test suites on GHA, so I'm wondering if this is in that suite.
| f'/{API_BASE}nodes/{component_project._id}/contributors/?copy_contributors_from_parent_project=true', | ||
| { | ||
| 'data': { | ||
| 'type': 3 |
There was a problem hiding this comment.
This shouldn't work. It should require the type to match the endpoint (probably contributors. This test runs locally?
There was a problem hiding this comment.
it matches PATCH endpoint nodes/{component_project._id}/contributors
with query parameter it is possible to call a separate serializer to update contributors by taking it from parent,
if copy_contributors_from_parent_project=true. is passed because we use that serializer and don't require additional data to pass from client.
it goes ok
b087-8dbf-474d-9590-4b0eab8f1bdd.mp4
and video for UI testing is there
brianjgeiger
merged commit 05484eb
into
CenterForOpenScience:feature/pbs-25-21
2 participants
Purpose
Contributor page of components should offer option to import contributors from parent project.
Changes
Contributor page of components should offer option to import contributors from parent project.
PR is related to the following front end update
CenterForOpenScience/angular-osf#670
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9127