[ENG-9758] Make notification preferences use proper values#11441
Merged
Johnetordoff merged 1 commit intoCenterForOpenScience:feature/notification-refactor-p2-sfrom Nov 13, 2025
Conversation
Johnetordoff
merged commit 5d258cd
into
CenterForOpenScience:feature/notification-refactor-p2-s
8 checks passed
brianjgeiger
pushed a commit
to CenterForOpenScience/angular-osf
that referenced
this pull request
Nov 14, 2025
…rect notif (#761) - Ticket: https://openscience.atlassian.net/browse/ENG-9758 - Feature flag: n/a ## Purpose Make the notification preferences default and change to correct values. Corrosponses with this PR: CenterForOpenScience/osf.io#11441 ## Summary of Changes Simple logic changes to make dropdowns functional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ly model
Purpose
Works with CenterForOpenScience/angular-osf#760 to restore notification value picking
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9758