[ENG-10283] added ability to add/remove files of an archived registration under osf storage#11674
Open
ihorsokhanexoft wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-6from
Open
Conversation
felliott
requested changes
Apr 9, 2026
Member
felliott
left a comment
felliott
left a comment
There was a problem hiding this comment.
Looks reasonable. I've added a few nitpicks and some possibly-unhandled error cases. If those error cases are handled elsewhere, then I think you ignore them.
| <a href="{% url 'nodes:search' %}" class="btn btn-primary"> <i class="fa fa-search"></i></a> | ||
| <a href="{% url 'nodes:node-logs' guid=node.guid %}" class="btn btn-primary">View Logs</a> | ||
| {% include "nodes/remove_node.html" with node=node %} | ||
| {% include "nodes/remove_file.html" with node=node %} |
Member
There was a problem hiding this comment.
Nitpick: Can we delete this file? Is it used anywhere else?
| </div> | ||
| </div> | ||
| <div class="modal-footer"> | ||
| <button class="btn btn-danger" name="action" value="ham" type="submit">Confirm</button> |
Member
There was a problem hiding this comment.
nitpick: value="ham"? Is that needed?
| </div> | ||
| </div> | ||
| <div class="modal-footer"> | ||
| <button class="btn btn-danger" name="action" value="ham" type="submit">Confirm</button> |
| messages.error(request, 'No file found with the provided guid.') | ||
| return redirect(self.get_success_url()) | ||
|
|
||
| file = guid.referent |
Member
There was a problem hiding this comment.
Don't we need to verify that the guid referent is actually a File and not another project, user, etc.?
| messages.error(request, 'No file found with the provided guid.') | ||
| return redirect(self.get_success_url()) | ||
|
|
||
| file = guid.referent |
| return redirect(self.get_success_url()) | ||
|
|
||
| file = guid.referent | ||
| registration.files.filter(id=file.id).delete() |
Member
There was a problem hiding this comment.
What if the file exists, but not under the registration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openscience.atlassian.net/browse/ENG-10283